100326 - compressing folders having insufficient diskspace causes loss of mail

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect)

Description

[Maik Freudenberg]

i was using build 20010801 when this occured

Comment 1

[David :Bienvenu]

-> navin

Comment 2

[Navin Gupta]

Attachment: proposed fix

Comment 3

[Navin Gupta]

The fix is to bail out if the write fails and notifycompactCompleted. 
cc bienvenu for review. 

Comment 4

[Navin Gupta]

David, Can i get an r= ?

Comment 5

[David :Bienvenu]

why return NS_ERROR_OUT_OF_MEMORY?

Comment 6

[Navin Gupta]

Comment on attachment 50044 [details] [diff] [review]
proposed fix

this has r=bienvenu
provided I change
NS_ERROR_OUT_OF_MEMORY
to
NS_MSG_ERROR_WRITING_MAIL_FOLDER

which I will do so before checking in

Comment 7

[(not reading, please use [e-mail] instead)]

Comment on attachment 50044 [details] [diff] [review]
proposed fix

sr=sspitzer

Comment 8

[Navin Gupta]

fixed on trunk

Comment 9

[Scott MacGregor]

yikes....data losss...easily avoided. nsBranch+

Comment 10

[Jaime Rodriguez, Jr.]

check it in - PDT+

Comment 11

[Navin Gupta]

fixed on branch

Comment 12

[Sheela Ravindran]

using branch build -2001-09-25-05 win98 verified.
Compressing folder from the menu item when the disk space is full shows a dlg 
warning the disk space and compaction does not occur and there was no loss of 
message.

Comment 13

[Navin Gupta]

*** Bug 101938 has been marked as a duplicate of this bug. ***

Comment 14

[Sheela Ravindran]

removing the keyword vtrunk because I verified this on the trunk build too.  
build: 2001-11-09-06 win98
I filled up the temp folder, sent a message. Then I deleted a message from the 
inbox.  Then I selected compact folder from the menu item. 
When the disk space is full we display a dlg box" The folder 'inbox'could not be 
compacted because wiriting to folder failed.  Verify that you have enough disk 
space and that you have write privileges to the file system, then try again.
OK 
Then I saw that the thread pane was repainted with all the messages. Then I got 
another dlg from the windows system to clear the disk space.  I did so by 
clicking disk cleanup button.  
After clearing the disk space compacted folders and successfully received the 
message that I sent before compacting.

Comment 15

[Henrik Gemal]

*** Bug 220872 has been marked as a duplicate of this bug. ***