1003266 - Investigate slow buchet detection

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P3)

Description

[Wil Clouser [:clouserw]]

Mathieu said the buchet code was taking 3-4 seconds to execute in yogafire on the Tarako device.  We should look into why it takes so long and make it faster for fireplace too.

Comment 1

[Wil Clouser [:clouserw]]

maybe the answer to this is to wait for hasFeature() in 1.5

Comment 2

[Mathieu Pillard [:mat]]

Tested it, it's much, much faster on my flame (~ 100ms) but still too much, especially considering it's disabled for now because of the unreliability of our detection checks. On desktop it's negligible (less than 10ms on my desktop).

I vote for removal of the buchets code while we wait for the proper feature detection API.

Comment 3

[Wil Clouser [:clouserw]]

yes, it's disabled so we shouldn't be running it.  Still working on landing getFeature().

Comment 4

[Mathieu Pillard [:mat]]

Worth noting: we use a lot of `'something' in obj` code in buchets and the rest of fireplace, and it's twice as slow as `obj.something !== undefined`. Maybe we should investigate here, especially if we keep the buchets code.

Comment 5

[Andrew Williamson [:eviljeff]]

(In reply to Mathieu Pillard [:mat] from comment #2)
> I vote for removal of the buchets code while we wait for the proper feature
> detection API.

the proper feature detection API will only cover certain APIs that can't be correctly detected because they rely on privileged permissions.  So the majority of the existing code is going to be as now.

Comment 6

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/fireplace/commit/1283794e5f04e35b2c017dc3bd394c606fd2374b