Closed
Bug 1003273
Opened 11 years ago
Closed 5 years ago
Fix typo in HTML parser error message
Categories
(Core :: DOM: HTML Parser, defect)
Tracking
()
RESOLVED
FIXED
81 Branch
| Tracking | Status | |
|---|---|---|
| firefox81 | --- | fixed |
People
(Reporter: sideshowbarker, Assigned: sideshowbarker)
References
Details
Attachments
(3 files)
|
869 bytes,
patch
|
hsivonen
:
review+
|
Details | Diff | Splinter Review |
|
913 bytes,
patch
|
hsivonen
:
review+
|
Details | Diff | Splinter Review |
|
47 bytes,
text/x-phabricator-request
|
Details | Review |
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 8414590 [details] [diff] [review]
patch.TreeBuilder.table-error-message
Do I also need to do here what you described over in bug 1077211? That is, revise the string for errNonSpaceInTable accordingly and mint a new key for it, e.g. errNonSpaceInTable2?
Attachment #8414590 -
Flags: review?(hsivonen)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 8414590 [details] [diff] [review]
patch.TreeBuilder.table-error-message
(In reply to Michael[tm] Smith from comment #2)
> Comment on attachment 8414590 [details] [diff] [review]
> patch.TreeBuilder.table-error-message
r+ for the Java part.
> Do I also need to do here what you described over in bug 1077211? That is,
> revise the string for errNonSpaceInTable accordingly and mint a new key for
> it, e.g. errNonSpaceInTable2?
Yes, that's needed to keep Gecko in sync.
Attachment #8414590 -
Flags: review?(hsivonen) → review+
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8414590 [details] [diff] [review]
patch.TreeBuilder.table-error-message
pretty straight-forward fix of a spelling error.
|
|
Assignee | |
Updated•10 years ago
|
Summary: Fix typo in HTML parser error message: "insided" -> "inside" → Fix typo in HTML parser error message
|
|
Assignee | |
Comment 5•10 years ago
|
||
Note that dom/locales/en-US/chrome/layout/htmlparser.properties already has this change, from https://bugzilla.mozilla.org/show_bug.cgi?id=698866
Attachment #8591732 -
Flags: review?(hsivonen)
|
|
Assignee | |
Comment 6•10 years ago
|
||
(In reply to Henri Sivonen (:hsivonen) from comment #3)
> (In reply to Michael[tm] Smith from comment #2)
> > Do I also need to do here what you described over in bug 1077211? That is,
> > revise the string for errNonSpaceInTable accordingly and mint a new key for
> > it, e.g. errNonSpaceInTable2?
>
> Yes, that's needed to keep Gecko in sync.
It seems there's no change needed at this point to the C++ code or the dom/locales/en-US/chrome/layout/htmlparser.properties since those were already fixed in bug 698866
|
|
||
Updated•10 years ago
|
Attachment #8591732 -
Flags: review?(hsivonen) → review+
|
||
Updated•10 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
|
||
Comment 7•5 years ago
|
||
Another patch I've failed to land. :-( Sorry.
|
|
||
Comment 8•5 years ago
|
||
|
||
Updated•5 years ago
|
Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
Pushed by hsivonen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/00f0f2503c02
Fix "non-space characters insided a table" typo. DONTBUILD NPOTB r=alchen
|
||
Comment 10•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox81:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
|
|
||
Updated•5 years ago
|
Assignee: hsivonen → mike
You need to log in
before you can comment on or make changes to this bug.
Description
•