1003279 - Integrate new -oop command line argument for b2g-desktop into relevant mach commands

Status: RESOLVED WONTFIX

(Firefox Build System :: Mach Core, enhancement)

Description

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Since mach is being used to launch tests now, we need to be able to specify oop test launches through it. Since bug 998500 landed and we have the oop command line option in, it should be integrated into mach.

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

diff --git a/testing/mochitest/mach_commands.py b/testing/mochitest/mach_commands.py
--- a/testing/mochitest/mach_commands.py
+++ b/testing/mochitest/mach_commands.py
@@ -543,16 +543,20 @@ def B2GCommand(func):
         help='the path to a gecko distribution that should \
               be installed on the emulator prior to test')
     func = geckopath(func)
 
     nowindow = CommandArgument('--no-window', action='store_true', default=False,
         help='Pass --no-window to the emulator')
     func = nowindow(func)
 
+    oop = CommandArgument('--oop', action='store_true', default=False,
+        help='Pass --oop to the emulator')
+    func = oop(func)
+
     sdcard = CommandArgument('--sdcard', default="10MB",
         help='Define size of sdcard: 1MB, 50MB...etc')
     func = sdcard(func)
 
     emulator = CommandArgument('--emulator', default='arm',
         help='Architecture of emulator to use: x86 or arm')
     func = emulator(func)

Not sure if that is the right way to do that but it seems to work. In case someone is going to integrate this, the above code snipped might help.

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

B2G Desktop is dead, marking wontfix