100328 - [FIX][ps]support for printing of non-latin1 chars using of HTML->PS

Status: VERIFIED FIXED

(Core :: Printing: Output, defect)

Description

[Gena Gromov]

Here is a patch to allow printing much more characters using HTML->PS
printing subsystem. It's a replacement for real_unicodeshow PS routine,
it that uses a dictionary mapping unicode codes to glyph names, and then
uses glyphname to show given glyph.
---
The patch is created by ALTlinux team (www.altlinux.ru) and is used
in their package of mozilla.
Their SRPMs with this patch included are publically distributed since
spring 2001,
from ftp://ftp.altlinux.ru/pub/distributions/ALTLinux/Sisyphus/SRPMS/
(NOTE: their ftp supports passive mode only!)

Please give credit to them for their wonderfull patches somewhere in
release notes and/or documentation, if possible.

Comment 1

[Gena Gromov]

Attachment: patch

Comment 2

[David Illsley]

Adding patch keyword

Comment 3

[rods (gone)]

taking

Comment 4

[dcone (gone)]

r=dcone

Comment 5

[Brendan Eich [:brendan]]

The patch is out of date (XP_FilePrintf is no more, good ol' stdio fprintf
suffices on all relevant platforms).  Rod, can you apply the patch to the
version it was based on (one from around mid-September -- use cvs up -r to stick
to a rev or date near there that patches cleanly), then cvs up -A to bring the
changes forward.  You'll want to change the calls such as XP_FilePrintf to fprintf.

/be

Comment 6

[Gena Gromov]

Guys, please also take a look at #100324 - it also contains a related patch.

Comment 7

[rods (gone)]

Attachment: updated patch

Wow, that was painful. There was a conflict bringing it up to date. So it was
better to hand merge it.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Don, any chance of re-reviewing the merged patch?

Comment 9

[dcone (gone)]

r=dcone.. looks good. thanks.

Comment 10

[Brendan Eich [:brendan]]

Comment on attachment 59570 [details] [diff] [review]
updated patch

rs=[e-mail] if it compiles.	Recording dcone's r= with the patch
manager (please use it, it helps queryability).

/be

Comment 11

[Boris Zbarsky [:bzbarsky]]

Rod, could you check this in before it rots again?

Comment 12

[rods (gone)]

fixed

Comment 13

[Gena Gromov]

Guys, please see #100324 too - it contains a small patch tha affects only cyrillic. Majority of Mozillas in russia and ExUSSR are running with this patch applied and it helps alot. In the worst case it will affect only cyrillic documents (in russian, ukrainian, bulgarian, etc). Could you please apply it too? Thanks in advance.

Comment 14

[sujay]

Gena, please verify and mark verified fixed.

Comment 15

[Gena Gromov]

It works fine - thank you very much! Please don't forget to apply #100324 for us cyrillic users.