Closed
Bug 1003296
Opened 12 years ago
Closed 12 years ago
use Services.jsm more in specialpowersAPI.js
Categories
(Testing :: General, defect)
Testing
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla32
People
(Reporter: froydnj, Unassigned)
Details
Attachments
(1 file)
|
7.24 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Reporter | |
Comment 1•12 years ago
|
||
There's no reason we should be groveling around in XPCOM when Services.jsm has
all these services already. Might even be a bit faster, too.
Attachment #8414611 -
Flags: review?(jmaher)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 8414611 [details] [diff] [review]
use Services.jsm more in specialpowersAPI.js
Review of attachment 8414611 [details] [diff] [review]:
-----------------------------------------------------------------
I admit my services.jsm usage is very low, from what I can tell this looks good and assuming these are identical methods this looks good. Please test on try, including mobile platforms.
Attachment #8414611 -
Flags: review?(jmaher) → review+
|
|
||
Comment 3•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•