1003321 - [B2G] [Open C] [Homescreen] App icon copies can appear when moving apps between dock and homescreen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Chris Kreinbring [:CKreinbring]]

Attachment: Log of persistent icon copy

Description:
Moving app icons quickly between the dock and the homescreen can cause copies of the icon to appear.  These copies persist through page changes, app launches and screen lock/unlocks.  The only way to get rid of the copies is to restart the device.

Repro Steps:
1) Update Open C to Build ID: 20140428000206
2) Fill the homepage and dock with icons.  Source doesn't matter.
3) Flick an app from the dock to the homescreen.
4) Quickly tap the next app to move before the icons have a chance to relocate to compensate for the missing app.
5) Flick the selected app to the homescreen and observe the device's reaction.

Actual:
After moving, a second version of the icon (that cannot be interacted with) appears on the screen.  This copy persists on the screen until the device is restarted.

Expected:
The icons are moved to the appropriate location every time without errors.

Environmental Variables
Device: Open C 1.4 mozilla RIL
Build ID: 20140428000206
Gecko: https://hg.mozilla.org/releases/mozilla-aurora/rev/36f67ce46855
Gaia: d23e479e8a4ce0bc620acb2d7e2f82801aa4d0ea
Platform Version: 30.0a2
Firmware Version: P821A10-ENG_20140410

Notes:
Repro frequency: 20%
Link to failed test case: https://moztrap.mozilla.org/manage/cases/?filter-id=9254
See attached screenshot, video clip and logcat
The bug also repros when moving an app from the homescreen to the dock

Comment 1

[Chris Kreinbring [:CKreinbring]]

Attachment: Screenshot of persistent icon copy

Comment 2

[Chris Kreinbring [:CKreinbring]]

Attachment: Video of persistent icon copy

Comment 3

[Chris Kreinbring [:CKreinbring]]

Does not repro on Buri 1.4 mozilla RIL

Build ID: 20140428000206
Gecko: https://hg.mozilla.org/releases/mozilla-aurora/rev/36f67ce46855
Gaia: d23e479e8a4ce0bc620acb2d7e2f82801aa4d0ea
Platform Version: 30.0a2
Firmware Version: V1.2-device.cfg

Comment 4

[Jason Smith [:jsmith]]

Does this reproduce with the 1.3 Open C base image?

Comment 5

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

I was unable to reproduce this issue on the Open C 1.3 after 10 attempts

1.3 Environmental Variables:
Device: Open_C 1.3
BuildID: 20140505052400
Gaia: Unknown Git commit; build date shown here.
Gecko:
Version: 28.0
Firmware Version: P821A10-ENG_20140410

Comment 6

[Jason Smith [:jsmith]]

Can we check if this reproduces with the latest gaia/gecko on 1.4 with the latest Open C base image?

Comment 7

[Josh Schmitt [Joshs]]

(In reply to Jason Smith [:jsmith] from comment #6)
> Can we check if this reproduces with the latest gaia/gecko on 1.4 with the
> latest Open C base image?

Tested this issue on the latest 1.4 Open_C build and on the latest Open_C base image. 

The issue reproduces, a second version of the same app is shown on the screen.

1.4 Environmental Variables:
Device: Open_C 1.4
BuildID: 20140506000202
Gaia: b1242f33981024de59b8b4c26bacff8b876211b1
Gecko: fe4080728c60
Version: 30.0
Firmware Version: FFOS_US_EBAY_P821A10V1.0.0B06_LOG_DL

Comment 8

[Preeti Raghunath(:Preeti)]

Moving to 1.4 blocker.

Comment 9

[Josh Schmitt [Joshs]]

Issue repros on the first tinderbox 1.4 Open_C build, unable to get a regression window.

1.4 Environmental Variables:
Device: Open_C 1.4
BuildID: 20140424123005
Gaia: fc95009476fac9ce205a59b237d146ca7f6f42e7
Gecko: 37237034e45c
Version: 30.0a2
Firmware Version: P821A10V1.0.0B06_LOG_DL

Comment 10

[Gregor Wagner [:gwagner]]

Cristian, any idea whats going on here?

Comment 11

[Cristian Rodriguez (:crdlc)]

Honestly I don't have idea what it's happening here, sorry for that. I don't have this device and it seems that it is only reproducing there according to this thread. Is it reproducible in other devices?

(In reply to Gregor Wagner [:gwagner] from comment #10)
> Cristian, any idea whats going on here?

Comment 13

[Aus Lacroix [:aus]]

I'm having a lot of trouble reproducing this issue on my Open C with the latest v1.4 build. Same firmware version as listed. Is there any tips or tricks I'm missing to reproduce this a little bit more consistently?

Comment 14

[Jason Smith [:jsmith]]

Adding steps-wanted to see if we can get better STR to reproduce this.

Comment 15

[Lionel Mauritson]

I was able to reproduce this issue with the following steps:

1) Update and Open_C to build 20140514000204
2) Enable Wifi and go to the Marketplace and download around 15 apps.
3) Fill page 2 (One page to the right of the e.me page) with as many app icons as it can hold.
4) Fill the dock bar with as many app icons as it can hold.
5) Press and hold to enable icon moving and move an app icon from the dock to the homescreen above.
6) Quickly grab and try to move another app icon from the dock to the homescreen above (Try to do this before all the icons finish rearranging themselves)
7) Repeat steps 3 to 6 until an enlarged app icon persists on the screen. 
(Some icons may need to be moved back into position to fill the screen / dock)

This took about 5 attempts.

Comment 16

[Aus Lacroix [:aus]]

Boom! There it is.

E/GeckoConsole( 1021): [JavaScript Error: "TypeError: draggableElem.parentNode is null" {file: "app://homescreen.gaiamobile.org/gaia_build_defer_index.js" line: 106}]

Comment 17

[Jason Smith [:jsmith]]

Aus - What's the reason for the qawanted request?

Comment 18

[Aus Lacroix [:aus]]

Attachment: Pull Request - Cherry picked changeset from master that seems to fix the issue on my OpenC

Comment 19

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8424233 [details] [review]
Pull Request - Cherry picked changeset from master that seems to fix the issue on my OpenC

LGTM the patch

Comment 20

[Aus Lacroix [:aus]]

Fixed!

Commit (v1.4): https://github.com/mozilla-b2g/gaia/commit/6e1bacba06faf8803d4ff4b4d75b255526309904

Comment 21

[Aus Lacroix [:aus]]

This only required a merge of a pre-existing change-set from master. 2.0 is unaffected.

Comment 22

[mkruml]

Verified on both Open_C and Flame 1.4

Comment 23

[mkruml]

Checked previous base image (P821A10-ENG_20140410) and the issue still repro'd, so I am setting it back to Resolved - Fixed

1.4 Environmental Variables:
Device: Open_C 1.4 MOZ
BuildID: 20140523000202
Gaia: 16f7ef17feb08562aa6a3cfd6d561b2fcca652c0
Gecko: 9cc96d59cc30
Version: 30.0
Firmware Version: P821A10-ENG-20140410