Closed Bug 1003525 Opened 10 years ago Closed 10 years ago

Opening a message, feed, or newsgroup message in a tab results in an empty transparent tab

Categories

(Thunderbird :: Message Reader UI, defect)

Product:
Thunderbird
Component:
Message Reader UI
Type:
defect
Priority:
Not set
Severity:
major

Tracking

(thunderbird31+ fixed)

Status:
VERIFIED FIXED
Milestone:
Thunderbird 31.0
Tracking Flags:
Tracking Status
thunderbird31 + fixed

People

(Reporter: JoeS1, Assigned: aceman)

References

Details

(Keywords: regression)

Attachments

(1 file)

patch
1.20 KB, patch
squib
: review+
standard8
: approval-comm-aurora+
Details | Diff | Splinter Review 
Since today,s trunk update.
Not seeing anything related in the error console.

Safemode opens the message but without From/To info in the message reader header.

Self-build from http://hg.mozilla.org/mozilla-central/rev/90267d87c375
shows the same symptoms. So I expect to see the same tomorrow.
Additional weirdness: 
selecting a To: from the autocomlete dropdown does not insert the selection into the To: field
Keywords: regression
I'm seeing no such problems here with self built TB32 and also downloaded Daily (still TB31 because version patch landed after build). Tested on Win7.
WFM here with 0429 win32 daily
This is not reproducible on my work laptop, but I'll leave this open until I investigate further on my home system.
The autocomplete selection issue you see would probably be bug 1003856.
So, toggling View>>Headers to normal fixes the display.
To reproduce:
Set View>>Headers to all
restart TB
attempt to view a message in a tab (or view it in the preview pane)
Attached patch patch — — Splinter Review 
Can you try this please? I do not understand how I overlooked to replace that one call in bug 898860.
Assignee: nobody → acelists
Status: NEW → ASSIGNED
Attachment #8415620 - Flags: review?(squibblyflabbetydoo)
Attachment #8415620 - Flags: feedback?(jsabash)
Blocks: 898860
Component: Toolbars and Tabs → Message Reader UI
OS: Windows 7 → All
Hardware: x86_64 → All
Comment on attachment 8415620 [details] [diff] [review]
patch

Review of attachment 8415620 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me
Attachment #8415620 - Flags: review?(squibblyflabbetydoo) → review+
Self build with the attachment fixes it for me
OK, let's try to land it.
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/90137d612f5b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 32.0
I've seen this working in today's nightly. Please verify the fix so we can push it to Aurora too.
tracking-thunderbird31: --- → ?
Flags: needinfo?(jsabash)
Verified fixed in 20140506030207
Status: RESOLVED → VERIFIED
tracking-thunderbird31: ? → ---
Component: Message Reader UI → Toolbars and Tabs
Flags: needinfo?(jsabash)
OS: All → Windows 7
Hardware: All → x86_64
Target Milestone: Thunderbird 32.0 → ---
I think the hardware, OS and Component fields were set right (it was bug in the common JS code affecting all platforms and was in the message reader code).
Comment on attachment 8415620 [details] [diff] [review]
patch

[Approval Request Comment]
Regression caused by (bug #): bug 898860
User impact if declined: empty message header fields
Testing completed (on c-c, etc.): trunk 20140506030207
Risk to taking this patch (and alternatives if risky): probably none (renaming nonexistent function to one that does exist now)
Attachment #8415620 - Flags: feedback?(jsabash) → approval-comm-aurora?
Bugzilla doesn't pre-fill those fields with existing data, Annoying
Component: Toolbars and Tabs → Message Reader UI
OS: Windows 7 → All
Hardware: x86_64 → All
Target Milestone: --- → Thunderbird 32.0
Attachment #8415620 - Flags: approval-comm-aurora? → approval-comm-aurora+
Target Milestone: Thunderbird 32.0 → Thunderbird 31.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: