1003537 - Configure fails to run js/src/config.status when it is not executable

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Michael Shal [:mshal]]

From configure:

...
configure: WARNING: unrecognized options: --with-compiler-wrapper
Traceback (most recent call last):
  File "/home/mshal/mozilla-central-git/build/subconfigure.py", line 135, in <module>
    dump(CONFIG_DUMP, sys.argv[2])
  File "/home/mshal/mozilla-central-git/build/subconfigure.py", line 92, in dump
    stderr=subprocess.STDOUT).splitlines()
  File "/usr/lib/python2.7/subprocess.py", line 573, in check_output
    raise CalledProcessError(retcode, cmd, output=output)
subprocess.CalledProcessError: Command '['/bin/sh', '-c', './config.status --help']' returned non-zero exit status 126
configuring in js/src
...

This seems to be because obj/js/src/config.status is generated without the execute bit (because JS_STANDALONE isn't set). However, configure still tries to run it.

Note this doesn't actually cause configure to fail normally, but when run through mozharness, the "Traceback" message is picked up as an error.

glandium says this is a side-effect of bug 969164.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Turn config.status executable in MOZ_CREATE_CONFIG_STATUS instead of MOZ_RUN_CONFIG_STATUS

Comment 2

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5e319b96c52f

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5e319b96c52f