Closed Bug 1003575 Opened 12 years ago Closed 11 years ago

Theme transparency not working

Categories

(addons.mozilla.org Graveyard :: Public Pages, defect, P1)

Product:
addons.mozilla.org Graveyard
Component:
Public Pages
Platform:
x86
macOS
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
2014-06

People

(Reporter: amyt, Assigned: yboniface)

References

Details

Attachments

(2 files)

Screenshot from 2014-05-12 17:59:42.png
36.79 KB, image/png
Details
Screenshot from 2014-05-12 18:03:20.png
55.06 KB, image/png
Details
Themes with a transparent backgrounds are showing up as opaque black. More details: https://forums.mozilla.org/addons/viewtopic.php?f=30&t=16637&sid=20a4df8f12081da49309c332c610fb08 This is affecting new and edited themes, and the problem seems to have started two weeks ago.
This sounds a lot like bug 373675 from a zillion years ago.
Priority: -- → P1
Target Milestone: --- → 2014-06
Assignee: nobody → yboniface
It works for me both locally and in -dev with the same exact files, so I guess it has to do with the local configuration/system. I will ping the devops to have their thoughts on this.
We did install/upgrade pngcrush on these hosts a few weeks ago https://bugzilla.mozilla.org/show_bug.cgi?id=993159.
Quick record of our point of yesterday: issue is not reproducible even in stage, Jason will have a look on prod conf today.
Flags: needinfo?(jthomas)
It looks like whatever you choose as 'Background Color' when submitting your theme becomes the background color once installed. I believe the default option is black. Black: https://addons.mozilla.org/en-US/firefox/addon/jasonthomas-test1/ Purple: https://addons.mozilla.org/en-US/firefox/addon/jasonthomas-test2/ The background color is being set in lightweightThemes.usedThemes as 'accentcolor'. For my purple background theme accent color is set to that value: [{"id":"512986","name":"jasonthomas-test2","headerURL":"https://addons.cdn.mozilla.net/_files/512986/header.png?1400094154","footerURL":"https://addons.cdn.mozilla.net/_files/512986/footer.png?1400094154","textcolor":"#ff0000","accentcolor":"#7f007f","iconURL":"https://addons.cdn.mozilla.net/_files/512986/icon.png?1400094154","previewURL":"https://addons.cdn.mozilla.net/_files/512986/preview.png?1400094154","author":"jason","description":"None","updateURL":"https://versioncheck.addons.mozilla.org/en-US/themes/update-check/512986","version":"1.0"},{"id":"64021","name":"transparent gray grill","headerURL":"https://addons.cdn.mozilla.net/_files/64021/header.png?1264381769","footerURL":"https://addons.cdn.mozilla.net/_files/64021/footer.png?1264381769","textcolor":"#000000","accentcolor":"#","iconURL":"https://addons.cdn.mozilla.net/_files/64021/preview_small.jpg?1264381769","previewURL":"https://addons.cdn.mozilla.net/_files/64021/preview.jpg?1264381769","author":"darkprop","description":"simply semitransparent gray grill","updateURL":"https://versioncheck.addons.mozilla.org/it/themes/update-check/64021","version":"1.0"},{"id":"490284","name":"jasonthomas-test1","headerURL":"https://addons-dev-cdn.allizom.org/_files/490284/header.png?1400095288","footerURL":"https://addons-dev-cdn.allizom.org/_files/490284/footer.png?1400095288","textcolor":"#000000","iconURL":"https://addons-dev-cdn.allizom.org/_files/490284/icon.png?1400095288","previewURL":"https://addons-dev-cdn.allizom.org/_files/490284/preview.png?1400095288","author":"jason","description":"None","updateURL":"https://versioncheck.addons.mozilla.org/en-US/themes/update-check/490284","version":"1.0"},{"id":"512978","name":"jasonthomas-test1","headerURL":"https://addons.cdn.mozilla.net/_files/512978/header.png?1400093250","footerURL":"https://addons.cdn.mozilla.net/_files/512978/footer.png?1400093250","textcolor":"#000000","iconURL":"https://addons.cdn.mozilla.net/_files/512978/icon.png?1400093250","previewURL":"https://addons.cdn.mozilla.net/_files/512978/preview.png?1400093250","author":"jason","description":"None","updateURL":"https://versioncheck.addons.mozilla.org/en-US/themes/update-check/512978","version":"1.0","updateDate":1400094570243,"installDate":1400094570243}] When I remove 'accentcolor' here, the background of theme because transparent once firefox is restarted. For theme https://addons.mozilla.org/it/firefox/addon/transparent-gray-grill/ (which is working) is not setting 'accentcolor' in lightweightThemes.usedThemes. [{"id":"64021","name":"transparent gray grill","headerURL":"https://addons.cdn.mozilla.net/_files/64021/header.png?1264381769","footerURL":"https://addons.cdn.mozilla.net/_files/64021/footer.png?1264381769","textcolor":"#000000","accentcolor":"#","iconURL":"https://addons.cdn.mozilla.net/_files/64021/preview_small.jpg?1264381769","previewURL":"https://addons.cdn.mozilla.net/_files/64021/preview.jpg?1264381769","author":"darkprop","description":"simply semitransparent gray grill","updateURL":"https://versioncheck.addons.mozilla.org/it/themes/update-check/64021","version":"1.0"},{"id":"512986","name":"jasonthomas-test2","headerURL":"https://addons.cdn.mozilla.net/_files/512986/header.png?1400094154","footerURL":"https://addons.cdn.mozilla.net/_files/512986/footer.png?1400094154","textcolor":"#ff0000","accentcolor":"#7f007f","iconURL":"https://addons.cdn.mozilla.net/_files/512986/icon.png?1400094154","previewURL":"https://addons.cdn.mozilla.net/_files/512986/preview.png?1400094154","author":"jason","description":"None","updateURL":"https://versioncheck.addons.mozilla.org/en-US/themes/update-check/512986","version":"1.0"},{"id":"490284","name":"jasonthomas-test1","headerURL":"https://addons-dev-cdn.allizom.org/_files/490284/header.png?1400095288","footerURL":"https://addons-dev-cdn.allizom.org/_files/490284/footer.png?1400095288","textcolor":"#000000","iconURL":"https://addons-dev-cdn.allizom.org/_files/490284/icon.png?1400095288","previewURL":"https://addons-dev-cdn.allizom.org/_files/490284/preview.png?1400095288","author":"jason","description":"None","updateURL":"https://versioncheck.addons.mozilla.org/en-US/themes/update-check/490284","version":"1.0"},{"id":"512978","name":"jasonthomas-test1","headerURL":"https://addons.cdn.mozilla.net/_files/512978/header.png?1400093250","footerURL":"https://addons.cdn.mozilla.net/_files/512978/footer.png?1400093250","textcolor":"#000000","iconURL":"https://addons.cdn.mozilla.net/_files/512978/icon.png?1400093250","previewURL":"https://addons.cdn.mozilla.net/_files/512978/preview.png?1400093250","author":"jason","description":"None","updateURL":"https://versioncheck.addons.mozilla.org/en-US/themes/update-check/512978","version":"1.0","updateDate":1400094570243,"installDate":1400094570243}]
Flags: needinfo?(jthomas)
So, what I think is that we hit another time the landing of the native color picker in Firefox 29.0 (See https://bugzilla.mozilla.org/show_bug.cgi?id=1005206#c1 for more details). The difference with the javascript color picker is that the native one doesn't allow empty value, and defaults to #000000. So as soon as the form is displayed, the default value is added. While with the javascript one, no value was added until the user has chosen one. Sadly, the spec said that "In this state, there is always a color picked, and there is no way to set the value to the empty string." I'm about to fill a bug anyway: I don't get that a widget would force a field value without the user to do anything, and I don't get how useful can be a widget that doesn't allow to empty the value. Also, now that we have two bugs linked to the native color picker, maybe we should artificially force the javascript one, and wait for the native to reach a stable state to rely on it. Thoughts?
(In reply to Yohan Boniface [:ybon] from comment #7) > So, what I think is that we hit another time the landing of the native color > picker in Firefox 29.0 (See > https://bugzilla.mozilla.org/show_bug.cgi?id=1005206#c1 for more details). > The difference with the javascript color picker is that the native one > doesn't allow empty value, and defaults to #000000. So as soon as the form > is displayed, the default value is added. While with the javascript one, no > value was added until the user has chosen one. > Sadly, the spec said that "In this state, there is always a color picked, > and there is no way to set the value to the empty string." > I'm about to fill a bug anyway: I don't get that a widget would force a > field value without the user to do anything, and I don't get how useful can > be a widget that doesn't allow to empty the value. > Also, now that we have two bugs linked to the native color picker, maybe we > should artificially force the javascript one, and wait for the native to > reach a stable state to rely on it. > > Thoughts? Yes, let's flip back to the JS one. Thanks for investigating and filing bugs.
Depends on: 1012893
Forcing javascript color picker has been merged: https://github.com/mozilla/olympia/commit/1167d361d6d0c8d06e3a28d6c736434522b3272e I'm closing here, and I will open a new bug for tracking the need to switch back to native one when ready.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
I can still reproduce the original issue. I have submitted a new theme using the png files used for this theme: https://addons.mozilla.org/it/firefox/addon/transparent-gray-grill/ - You can install that theme and see the transparency work This is the theme submitted by me: https://addons-dev.allizom.org/en-US/firefox/addon/testtransparenttheme/ The theme is not transparent neither on theme detail page or after you install it. Please view this screencast: http://screencast.com/t/PMoNtgtrTE Reopening.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
@Madalin, I see that the "accentcolor" (background) of the theme your created is "#000000", have you set this color yourself? This is what causes the background to be black when you install the theme. If I try locally, creating a new theme without setting any color, no color is set (which is the expected behaviour). I may be missing something, because I'm not familiar at all with the process of installing a them in Firefox.
@Yohan I think you are right and I accidentally set the background color to black for that theme. I have investigated again the issue and now everything appears to be working as expected. Here is a screencast with the submission flow and installing the theme: http://screencast.com/t/moxM9bnJg1LK Thank you!
Target Milestone: 2014-06 → 2014-07
Fixed in https://github.com/yohanboniface/olympia/commit/1167d361d6d0c8d06e3a28d6c736434522b3272e
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Target Milestone: 2014-07 → 2014-06
Verified as fixed.
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: