1003605 - Intermittent b2g30 test_interfaces.html | If this is failing: DANGER, are you sure you want to expose the new interface CSSFontFeatureValuesRule to all webpages as a property on the window?

Status: RESOLVED WORKSFORME

(Core :: DOM: Core & HTML, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

Interestingly, I don't recall seeing this ever on Aurora before the uplift on Monday. Yet first there was this instance below from a B2G opt emulator run, and forthcoming logs on Windows debug as well.

https://tbpl.mozilla.org/php/getParsedLog.php?id=38656665&tree=Mozilla-B2g30-v1.4

b2g_emulator_vm mozilla-b2g30_v1_4 opt test mochitest-7 on 2014-04-28 13:21:41 PDT for push 129018b8b543
slave: tst-linux64-spot-104

13:56:40     INFO -  1391 INFO TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/general/test_interfaces.html | If this is failing: DANGER, are you sure you want to expose the new interface CSSFontFeatureValuesRule to all webpages as a property on the window? Do not make a change to this file without a  review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)

Comment 1

[Ryan VanderMeulen [:RyanVM]]

The later Windows build (hit all 3 Windows platforms):
http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-b2g30_v1_4-win32-debug/1398803707/

https://tbpl.mozilla.org/php/getParsedLog.php?id=38746386&tree=Mozilla-B2g30-v1.4
https://tbpl.mozilla.org/php/getParsedLog.php?id=38746784&tree=Mozilla-B2g30-v1.4
https://tbpl.mozilla.org/php/getParsedLog.php?id=38746887&tree=Mozilla-B2g30-v1.4

I'm going to be cloning this bug shortly for similar looking mochitest-bc failures on this same Windows build.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

I've also clobbered b2g30 and retriggered this build. AFAICT, it wasn't clobbered yesterday during all the various uplifts.

Comment 3

[Boris Zbarsky [:bzbarsky]]

So the entry in test_interfaces here is:

     {name: "CSSFontFeatureValuesRule", release: false},

So on aurora, this property was expected to be enabled.  On beta, it's expected to be disabled.

In theory, this is controlled by the fact that in OldBindingConstructorEnabled we do:

  if (aStruct->mDOMClassInfoID == eDOMClassInfo_CSSFontFeatureValuesRule_id) {
    return nsCSSFontFeatureValuesRule::PrefEnabled();
  }

which in turn returns nsCSSProps::IsEnabled(eCSSProperty_font_variant_alternates) which is controlled by the "layout.css.font-features.enabled" pref, which is true only ifndef RELEASE_BUILD.

So this should all work, in theory....

Comment 4

[Ryan VanderMeulen [:RyanVM]]

This appears to have gone away. Yay.

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Was this actually intermittent?  That seems crazy ...

Comment 6

[Ryan VanderMeulen [:RyanVM]]

It was around the time of the uplift and it was felt that there was a possibility it was clobber-related. No occurrences since seems to support that theory.