1003615 - Readability add-on buttons do not work since Firefox 29

Status: RESOLVED FIXED

(WebExtensions :: General, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

Add-on URL: https://www.readability.com/addons

In the Browser Console, I see:

ReferenceError: BrowserToolboxCustomizeDone is not defined rdb.firefox.js:132

BrowserToolboxCustomizeDone was removed in Firefox 29. Here's the offending code:


        var insert_before = 'urlbar-container',
            //
            nav_bar = document.getElementById('nav-bar'),
            current_set_array = nav_bar.currentSet.split(','),
            //
            new_set;

        // Install all the buttons one by one
        for(var button_index in toolbar_buttons){
            if(toolbar_buttons.hasOwnProperty(button_index)){
                var button = toolbar_buttons[button_index],
                    insert_index = current_set_array.indexOf(insert_before);

                // Only install the button if it's not already in the set
                if(current_set_array.indexOf(button) === -1){
                    current_set_array.splice(insert_index, 0, button);
                }
            }
        }

        // Set the toolbar to the current set
        new_set = current_set_array.join(",");
        nav_bar.setAttribute('currentset', new_set);
        nav_bar.currentSet = new_set;
        document.persist("nav-bar", "currentset");
        //nav_bar.ownerDocument.persist(nav_bar.id, 'currentset');
        BrowserToolboxCustomizeDone(true);

The currentSet stuff should technically still work, but they should probably be using CustomizableUI[1] instead to add these widgets. BrowserToolboxCustomizeDone is definitely gone, and the root of the issue. If they still need to detect when customization is done, they should listen for the "aftercustomization" event[2].

[1]: https://developer.mozilla.org/en-US/docs/Mozilla/JavaScript_code_modules/CustomizableUI.jsm
[2]: https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/Toolbars/Toolbar_customization_events

Comment 1

[Jorge Villalobos [:jorgev] (he/him)]

The add-on has been marked as incompatible. It hasn't been updated in over a year, so it's unlikely it will be updated.

Comment 2

[Philip Forget]

Hi guys,

I'm aware that the addon has been set to incompatible, I'm fixing it as we speak but it's a bit slow going lately. The new addon should be out soon and will address this. Sorry for the delay!

Philip