Closed
Bug 1003620
Opened 10 years ago
Closed 10 years ago
Add QR encoder library
Categories
(DevTools Graveyard :: WebIDE, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 32
People
(Reporter: jryans, Assigned: jryans)
References
Details
Attachments
(1 file, 2 obsolete files)
51.06 KB,
patch
|
jryans
:
review+
|
Details | Diff | Splinter Review |
For WiFi debugging, we intend to exchange keys via a QR code that is scanned with the phone. To support this, we need to generate a QR code. There appears to be one main JS encoder[1], and others just wrap it. I'll wrap it with a simple API. The encoder is under the MIT license, but I'll also request a license review. [1]: https://github.com/kazuhikoarase/qrcode-generator
Assignee | ||
Comment 1•10 years ago
|
||
The includes: * external library at |toolkit/devtools/qrcode/encoder/encoder.js| (patched to export some bits as a module) * small wrapper API at |toolkit/devtools/qrcode/qrcode.js|
Attachment #8414959 -
Flags: review?(paul)
Assignee | ||
Comment 2•10 years ago
|
||
The licensing review will take place in bug 1003640.
Assignee | ||
Comment 3•10 years ago
|
||
Try: https://tbpl.mozilla.org/?tree=Try&rev=3ec9c91e4328
Updated•10 years ago
|
Attachment #8414959 -
Flags: review?(paul) → review+
Assignee | ||
Comment 4•10 years ago
|
||
* Removed trademark statement per discussion in bug 1003640 * Added to Android and b2g test manifests * Changed file names slightly Try: https://tbpl.mozilla.org/?tree=Try&rev=3f4e491e4319
Attachment #8414959 -
Attachment is obsolete: true
Attachment #8415994 -
Flags: review+
Assignee | ||
Comment 5•10 years ago
|
||
Added author info to the commit message as suggested by the licensing FAQ.
Attachment #8415994 -
Attachment is obsolete: true
Attachment #8416091 -
Flags: review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 6•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/4dce6f797661
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4dce6f797661
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 32
Updated•6 years ago
|
Product: Firefox → DevTools
Updated•4 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•