1003632 - Some text Image are not drawn. And Background is rectangle instead of hexagon.

Status: RESOLVED INVALID

(Core :: Graphics: ImageLib, defect)

Description

[Alice0775 White]

Attachment: Screenshot

Steps To Reproduce:
1. Open http://www.fishgl.com/
   --- observe LOGO and progress animation

Actual Results:
No Text Image is drawn.
Background shape is Rectangle.

Expected Results:
Some text and [e] image should be drawn.
Background should be hexagon.

Regression window(m-c)
Good:
https://hg.mozilla.org/mozilla-central/rev/5c0673441fc8
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0 ID:20140324134644
Bad:
https://hg.mozilla.org/mozilla-central/rev/83332ca5291a
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0 ID:20140325051943
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5c0673441fc8&tochange=83332ca5291a


Regression window(m-i)
Good:
https://hg.mozilla.org/integration/mozilla-inbound/rev/53fcaeb264ba
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0 ID:20140324131440
Bad:
https://hg.mozilla.org/integration/mozilla-inbound/rev/db4bcc7605be
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0 ID:20140324141343
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=53fcaeb264ba&tochange=db4bcc7605be

Suspected: Bug 980488 or Bug 987002

Comment 1

[xunxun]

I built 29.0 with Bug 987002 patch, and have not reproduced the issue on Win8 x64.

Comment 2

[Alice0775 White]

In local build,
Last Good: 74fa10a83ce8
First Bad: 5f91b2fc6812 +db4bcc7605be

Regressed by: Bug 980488

Comment 3

[Alice0775 White]

Attachment: Reduced html

Comment 4

[Glenn Randers-Pehrson]

The handling of PNG files with bad CRC checksums changed in libpng-1.6.10.  Both of the base-64-encoded PNG files in the "reduced html" sample have bad checksums in their IEND chunks.

Comment 5

[Milan Sreckovic [:milan] (needinfo for best results)]

So, is the libpng now correct but less forgiving and there is nothing we can or should do?  Or is the handling changed and we are now not ready for the "failure" and mess things up on our end?

Comment 6

[Glenn Randers-Pehrson]

Yes, libpng is more correct and less forgiving.

Comment 7

[Glenn Randers-Pehrson]

I extracted one of the two images from the "reduced.html".  Here are the last few characters:
7+xEwgeNydPfIAECyOvsew9q5v8P9VK6p5MN7msAAAAASUVORK5CIIA=

I then ran "pngfix" (from the libpng16 tools directory) and converted it back to base64.  All
but the last 3 characters were the same, and the last 3 were IIA in the bad file and
YII in the fixed file.

fixed base64 image
7+xEwgeNydPfIAECyOvsew9q5v8P9VK6p5MN7msAAAAASUVORK5CYII=

However, after making this fix, reduced.html still only shows me a blue and white rectangle
without any text or hexagonal logo.  The two images look OK when displayed separately from the
html.

Comment 8

[Glenn Randers-Pehrson]

Attachment: reduced_fixed.html (reduced.html with CRCs fixed)

Comment 9

[Glenn Randers-Pehrson]

Attachment: reduced_fixed.html (reduced.html with CRCs fixed)

Comment 10

[Glenn Randers-Pehrson]

I had a couple of wrong characters in the reduced_fixed.html so have uploaded a corrected file.  Firefox shows it correctly.

Comment 11

[Glenn Randers-Pehrson]

Attachment: v02 reduced_fixed.html (reduced.html with CRCs fixed)

I had only fixed the CRC in the logo.  Here is a replacement with the CRC fixed in the text image as well.

Comment 12

[Glenn Randers-Pehrson]

By the way, I'm observing the behavior on Ubuntu 14.04 so am changing the "platform" from Windows 7 to "all".

Comment 13

[Sylvestre Ledru [:Sylvestre]]

Glenn, any news on this bug? Thanks

Comment 14

[Glenn Randers-Pehrson]

The bug is with the CRC in the images.  Fixing the images, as in the v02 attachment, fixes the display.

Comment 15

[Sylvestre Ledru [:Sylvestre]]

OK. So, that is not really a Firefox issue if I understand correctly. Therefor, untracking.

Comment 16

[Glenn Randers-Pehrson]

Resolving INVALID because the bug is in the PNG files, not in Firefox.  Rejecting PNG files that have an incorrect CRC in a critical chunk (such as IEND) is what the PNG spec tells us to do.