1003652 - Always turn on ril debugging in telephony marionette test

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Szu-Yu Chen [:aknow] (inactive)]

Recently, we encounter several time out in telephony marionette tests executed on try server. However, it's difficult to dig into the problem without the ril debugging log. So I would like to always turn on the debugging in those test cases.

Will it cause any problem?

Comment 1

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: Turn on debugging in marionette test

Achieve by altering the pref value during tests.

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8414980 [details] [diff] [review]
Turn on debugging in marionette test

Review of attachment 8414980 [details] [diff] [review]:
-----------------------------------------------------------------

I think Jonathan is a properer reviewer.

Comment 3

[Szu-Yu Chen [:aknow] (inactive)]

(In reply to Hsin-Yi Tsai  [:hsinyi] from comment #2)
> Comment on attachment 8414980 [details] [diff] [review]
> Turn on debugging in marionette test
> 
> Review of attachment 8414980 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I think Jonathan is a properer reviewer.

... ?
The modification is done in telephony's head.js

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Szu-Yu Chen [:aknow] from comment #3)
> (In reply to Hsin-Yi Tsai  [:hsinyi] from comment #2)
> > Comment on attachment 8414980 [details] [diff] [review]
> > Turn on debugging in marionette test
> > 
> > Review of attachment 8414980 [details] [diff] [review]:
> > -----------------------------------------------------------------
> > 
> > I think Jonathan is a properer reviewer.
> 
> ... ?
> The modification is done in telephony's head.js

Aknow, sorry for not explaining myself. The change itself is fine for me, but I am not sure how it would afect the whole marrionet process. Vicamo told me that marionette process has been killed due to a large logging message. Is the situation still? This pref not only works for TelephonyProvider module but also for ril_worker, rilcontenthelper , data connection ... the message size is obvious. That's why I think I would like to have Jonathan's review. The other thing is turning on debugging might longer the test time. We shall be more careful to not lead to more timeout possibilities. Thank you.

Comment 5

[Hsin-Yi Tsai (she/her) [:hsinyi]]

According to timeout, we could solve it by splitting the cases or extand the time, so not that serious. Just to make sure we have enough tests on try before landing.

Comment 6

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8414980 [details] [diff] [review]
Turn on debugging in marionette test

Review of attachment 8414980 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, but I still like to see if Jonathan is okay with this (see comment 4), thanks.

Comment 7

[Szu-Yu Chen [:aknow] (inactive)]

(In reply to Hsin-Yi Tsai  [:hsinyi] from comment #5)
> According to timeout, we could solve it by splitting the cases or extand the
> time, so not that serious. Just to make sure we have enough tests on try
> before landing.

It's time out, but not means the running time is not enough.

What I found is that some events are missing and it cause our test script stuck at somewhere. We can not dig into the problem without the log. All we can do is to enable the log and retest it on the try server. It wastes the time and is not guaranteed reproducible.

Comment 8

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Szu-Yu Chen [:aknow] from comment #7)
> (In reply to Hsin-Yi Tsai  [:hsinyi] from comment #5)
> > According to timeout, we could solve it by splitting the cases or extand the
> > time, so not that serious. Just to make sure we have enough tests on try
> > before landing.
> 
> It's time out, but not means the running time is not enough.
> 
> What I found is that some events are missing and it cause our test script
> stuck at somewhere. We can not dig into the problem without the log. All we
> can do is to enable the log and retest it on the try server. It wastes the
> time and is not guaranteed reproducible.

Totally agree!

Comment 9

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8414980 [details] [diff] [review]
Turn on debugging in marionette test

Review of attachment 8414980 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm; I don't think this should cause any problems for our test infrastructure

Comment 10

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: [final] Turn on debugging in marionette test. r=hsinyi, jgriffin

Comment 11

[Szu-Yu Chen [:aknow] (inactive)]

https://tbpl.mozilla.org/?tree=Try&rev=f4b175787a10

Comment 12

[Hsin-Yi Tsai (she/her) [:hsinyi]]

https://hg.mozilla.org/integration/b2g-inbound/rev/219cb1047f3b

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/219cb1047f3b