1003672 - push-to-device.js cannot kill app with long names

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

+++ This bug was initially created as a clone of Bug #915484 +++

It looks like apps like "Built-in Keyboard" is shown as "Built-in Keyboa" in b2g-info. Instead of matching the whole app name, we should just match "Built-in Keyboa".

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

s/b2g-info/b2g-ps/

Comment 2

[Mozilla Shepherd (This account is used for automation and doesn't receive bugmail)]

Attachment: mozilla-b2g:master PR#18813

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8415013 [details] [review]
mozilla-b2g:master PR#18813

Dave, would you might give some input here first?

I am not sure the right way to fix this bug is to make the APPLICATION column longer or simply truncate the string in build script tools here.

https://github.com/mozilla-b2g/gonk-misc/blame/master/b2g-ps

Comment 4

[Dave Hylands [:dhylands]]

Yeah - the process name is truncated to 16 characters (including the terminating null) by the kernel. If you look inside the internal kernel data structures you'll see:
http://lxr.linux.no/#linux+v3.14.2/include/linux/sched.h#L265
http://lxr.linux.no/#linux+v3.14.2/include/linux/sched.h#L1320

So if you're going to compare, you need to truncate the string you're going to compare to be no more than 15 characters.

So you can't really make it any bigger.

Comment 5

[Dave Hylands [:dhylands]]

Comment on attachment 8415013 [details] [review]
mozilla-b2g:master PR#18813

That looks about right to me.

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Dave Hylands [:dhylands] from comment #4)
> Yeah - the process name is truncated to 16 characters (including the
> terminating null) by the kernel. If you look inside the internal kernel data
> structures you'll see:
> http://lxr.linux.no/#linux+v3.14.2/include/linux/sched.h#L265
> http://lxr.linux.no/#linux+v3.14.2/include/linux/sched.h#L1320
> 
> So if you're going to compare, you need to truncate the string you're going
> to compare to be no more than 15 characters.
> 
> So you can't really make it any bigger.

Thanks for the explanation!

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/0d705e63223f07a9fd4859cf85af267dc6de18c7