1003739 - [Settings][Bluetooth] Migrate pairing flow from settings to bluetooth app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Bluetooth, defect)

Description

[[e-mail], [e-mail]]

Since Settings app is refactoring, we propose to migrate Bluetooth pairing process from Settings app to Bluetooth app. It will avoid to launch Settings app while a pairing request is coming each time.

Comment 1

[[e-mail], [e-mail]]

Attachment: pull request 18930

Arthur, 

The patch here is same with bug 989742. Then, I add unit tests for all of them. Could you please help to review my pr? Thanks.

Comment 2

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8420010 [details] [review]
pull request 18930

Thanks for the patch! The code looks good to me. I've left some comments regarding the tests, please check them.

Comment 3

[[e-mail], [e-mail]]

Comment on attachment 8420010 [details] [review]
pull request 18930

Arthur, thanks for your reviewing effort with patient. I have update the patch with your suggestion. Please help to review it again. Thanks.

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8420010 [details] [review]
pull request 18930

Good work! r=me with a few nits addressed, thanks!

Comment 5

[[e-mail], [e-mail]]

Revise all of the nits and passed on Travis build. Merge the pr in Gaia/master: f6b80263b97f0e1f7d2edb725d23f5ab24f69ba4.

Comment 6

[[e-mail], [e-mail]]

Since worked on this patch, I find out two duplicated module/util 'BluetoothHelper', 'getTruncated'. They should be put in shared folder in the future. 

Follow up bugs:

Bug 1010106 - [Gaia][Bluetooth] Reuse Bluetooth helper in shared folder.
Bug 1010107 - [Gaia][Bluetooth File Transfer][Video] Put the duplicated utils 'getTruncated' in shared folder.

Comment 7

[Ton [:Tonnes]]

> +cancel=Cancel

As the cancel string was already present in bluetooth.properties, it now occurs twice…

Comment 8

[[e-mail], [e-mail]]

Ton, good catch on the duplicated string. I create a bug 1010646 for removing it. Thanks.