1003745 - [B2G] [RIL] [Tarako] get the right fail cause for a call after REQUEST_DIAL fails

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Hsin-Yi Tsai (she/her) [:hsinyi]]

This is valid for only v1.3T.

We simply assign "UnspecifiedError" to fail cause for a call after REQUEST_DIAL fails but this is not correct.

We should check if a pendingMO call has been hung up before. 1) If yes, assign the fail cause manually. 2) If not, go query GET_LAST_FAIL_CAUSE_CODE.

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

nominate 1.3T+ because it blocks another 1.3T+ bug 1001729.

Comment 2

[Joe Cheng [:jcheng] (please needinfo)]

triage: 1.3T+ as it blocks a 1.3T+ bug

Comment 3

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: Get correct fail cause

The case of hanging up pending call is handled in hangUp().
Then it just do nothing in REQUEST_DIAL handler => _removePendingOutgoingCall().

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8415126 [details] [diff] [review]
Get correct fail cause

Review of attachment 8415126 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you :)

::: dom/system/gonk/ril_worker.js
@@ +5254,5 @@
>  };
>  RilObject.prototype[REQUEST_DIAL] = function REQUEST_DIAL(length, options) {
>    // We already return a successful response before. Don't respond it again!
>    if (options.rilRequestError) {
>      options.callIndex = -1;

Please remove this as it's useless.

Comment 5

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: (1.3T) [final] Get correct fail cause. r=hsinyi

Comment 6

[Szu-Yu Chen [:aknow] (inactive)]

Please only land it on 1.3T

Comment 7

[[:fabrice] Fabrice Desré]

 https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/fcbc8ac41625