Closed Bug 1003745 Opened 6 years ago Closed 6 years ago

[B2G] [RIL] [Tarako] get the right fail cause for a call after REQUEST_DIAL fails

Categories

(Firefox OS Graveyard :: RIL, defect)

x86_64
Linux
defect
Not set

Tracking

(blocking-b2g:1.3T+, b2g-v1.3T fixed, b2g-v2.0 unaffected)

RESOLVED FIXED
2.0 S1 (9may)
blocking-b2g 1.3T+
Tracking Status
b2g-v1.3T --- fixed
b2g-v2.0 --- unaffected

People

(Reporter: hsinyi, Assigned: aknow)

References

Details

(Whiteboard: [p=2])

Attachments

(1 file, 1 obsolete file)

This is valid for only v1.3T.

We simply assign "UnspecifiedError" to fail cause for a call after REQUEST_DIAL fails but this is not correct.

We should check if a pendingMO call has been hung up before. 1) If yes, assign the fail cause manually. 2) If not, go query GET_LAST_FAIL_CAUSE_CODE.
nominate 1.3T+ because it blocks another 1.3T+ bug 1001729.
blocking-b2g: --- → 1.3T?
triage: 1.3T+ as it blocks a 1.3T+ bug
blocking-b2g: 1.3T? → 1.3T+
Attached patch Get correct fail cause (obsolete) — Splinter Review
The case of hanging up pending call is handled in hangUp().
Then it just do nothing in REQUEST_DIAL handler => _removePendingOutgoingCall().
Attachment #8415126 - Flags: review?(htsai)
Comment on attachment 8415126 [details] [diff] [review]
Get correct fail cause

Review of attachment 8415126 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you :)

::: dom/system/gonk/ril_worker.js
@@ +5254,5 @@
>  };
>  RilObject.prototype[REQUEST_DIAL] = function REQUEST_DIAL(length, options) {
>    // We already return a successful response before. Don't respond it again!
>    if (options.rilRequestError) {
>      options.callIndex = -1;

Please remove this as it's useless.
Attachment #8415126 - Flags: review?(htsai) → review+
Attachment #8415126 - Attachment is obsolete: true
Attachment #8415156 - Flags: review+
Please only land it on 1.3T
Keywords: checkin-needed
Flags: needinfo?(mhenretty)
Keywords: checkin-needed
Flags: needinfo?(mhenretty)
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S1 (9may)
Whiteboard: [p=2]
You need to log in before you can comment on or make changes to this bug.