1003770 - [Unit test] Unit test for shrinking UI

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[(inactive after 6/18) Alive Kuo [:alive]]

We need unit test for shrinking UI.

Comment 1

[John Lu [:mnjul][Please NI or I'll miss]]

Attachment: Patch

This is a WIP patch I'm working on (not all members of the module is being tested right now)

Comment 2

[John Lu [:mnjul][Please NI or I'll miss]]

Comment on attachment 8418591 [details] [review]
Patch

The patch is full and has passed Travis CI test: https://travis-ci.org/mozilla-b2g/gaia/builds/24943726 . Will be reviewed.

Comment 3

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8418591 [details] [review]
Patch

Looks good and provide detailed test.
You can fix the nits and then I'll merge this for you.

Comment 4

[John Lu [:mnjul][Please NI or I'll miss]]

awesome. i'll fix the nits asap.

Comment 5

[Greg Weng [:snowmantw][:gweng][:λ]]

Please fix Alive's addressed issues, too. Thanks.

Comment 6

[John Lu [:mnjul][Please NI or I'll miss]]

Hi Alive, could you confirm the issues in your comments have been addressed? Thanks

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

See github

Comment 8

[John Lu [:mnjul][Please NI or I'll miss]]

Hi alive, your comments have been addressed, see https://github.com/mozilla-b2g/gaia/pull/19022 . Could you confirm? Thanks.

Comment 9

[(inactive after 6/18) Alive Kuo [:alive]]

Please land.

Comment 10

[John Lu [:mnjul][Please NI or I'll miss]]

Awesome. @gweng could you merge for me? Much appreciated.

Comment 11

[Greg Weng [:snowmantw][:gweng][:λ]]

master: https://github.com/mozilla-b2g/gaia/commit/5311c60bf2ff1a5486e80eefcb8ca2a937638679