Closed Bug 1003771 Opened 7 years ago Closed 7 years ago

[Build System] Move out distribution_tablet/homescreen.json

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: chens, Assigned: chens)

References

Details

Attachments

(2 files, 1 obsolete file)

WIP
46 bytes, text/x-github-pull-request
yurenju
: feedback+
Details | Review
46 bytes, text/x-github-pull-request
yurenju
: review+
Details | Review
As 'distribution_tablet' folder will be removed in bug 996461, homescreen.json needs to move to a proper place. gaia/apps/homescreen/build/tablet/ could be the option.
Attached file WIP (obsolete) —
Hi Yuren, 

I'm currently working on this but not sure is this the right direction to go, could you take a look at the WIP and give some feedback? Thanks.
Assignee: nobody → shchen
Attachment #8415321 - Flags: feedback?(yurenju.mozilla)
Comment on attachment 8415321 [details] [review]
WIP

Chens, you should just add GAIA_DEVICE_TYPE to BUILD_CONFIG in Makefile and use |APP_DIR| & |GAIA_DEVICE_TYPE| to assemble configuration path in javascript like

by nsIFile:

> var configDIR = utils.getFile(options.APP_DIR, 'build', options.GAIA_DEVICE_TYPE);

or by String:

> var configPath = utils.joinPath(options.APP_DIR, 'build', options.GAIA_DEVICE_TYPE);
Attachment #8415321 - Flags: feedback?(yurenju.mozilla)
Attached file WIP
Hi Yuren, 

Here's another WIP, app config path is built with |APP_DIR| & |GAIA_DEVICE_TYPE|. And the settings will be extent instead overwrite, how do you think?
Attachment #8415321 - Attachment is obsolete: true
Attachment #8417244 - Flags: feedback?(yurenju.mozilla)
Comment on attachment 8417244 [details] [review]
WIP

looks good and I suggest using |if (config.GAIA_DEVICE_TYPE)| instead of |if (config.GAIA_DEVICE_TYPE !== '')|
Attachment #8417244 - Flags: feedback?(yurenju.mozilla) → feedback+
Attached file Pull request
Attachment #8417840 - Flags: review?(yurenju.mozilla)
Comment on attachment 8417840 [details] [review]
Pull request

r=yurenju, thanks!
Attachment #8417840 - Flags: review?(yurenju.mozilla) → review+
Merged to master, r=yurenju
https://github.com/mozilla-b2g/gaia/commit/e911619c22dfad8555d427b917491f5cba1fc9c0
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.