Closed Bug 1003771 Opened 7 years ago Closed 7 years ago
[Build System] Move out distribution
As 'distribution_tablet' folder will be removed in bug 996461, homescreen.json needs to move to a proper place. gaia/apps/homescreen/build/tablet/ could be the option.
Hi Yuren, I'm currently working on this but not sure is this the right direction to go, could you take a look at the WIP and give some feedback? Thanks.
Assignee: nobody → shchen
Hi Yuren, Here's another WIP, app config path is built with |APP_DIR| & |GAIA_DEVICE_TYPE|. And the settings will be extent instead overwrite, how do you think?
Comment on attachment 8417244 [details] [review] WIP looks good and I suggest using |if (config.GAIA_DEVICE_TYPE)| instead of |if (config.GAIA_DEVICE_TYPE !== '')|
Attachment #8417244 - Flags: feedback?(yurenju.mozilla) → feedback+
Comment on attachment 8417840 [details] [review] Pull request r=yurenju, thanks!
Attachment #8417840 - Flags: review?(yurenju.mozilla) → review+
Merged to master, r=yurenju https://github.com/mozilla-b2g/gaia/commit/e911619c22dfad8555d427b917491f5cba1fc9c0
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.