Closed Bug 1003772 Opened 10 years ago Closed 10 years ago

[Build System] Move out distribution_tablet/wallpapers

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: chens, Assigned: chens)

References

Details

Attachments

(2 files, 1 obsolete file)

46 bytes, text/x-github-pull-request
yurenju
: feedback+
Details | Review
46 bytes, text/x-github-pull-request
yurenju
: review+
Details | Review
As 'distribution_tablet' folder will be removed in bug 996461, wallpapers folder needs to move to a proper place. gaia/apps/wallpaper/build/tablet/ could be the option.
Attached file WIP (obsolete) —
Hi Yuren, 

I'm currently working on this but not sure is this the right direction to go, could you take a look at the WIP and give some feedback? Thanks.
Assignee: nobody → shchen
Attachment #8417158 - Flags: feedback?(yurenju.mozilla)
Comment on attachment 8417158 [details] [review]
WIP

same as bug 1003771.
Attachment #8417158 - Flags: feedback?(yurenju.mozilla)
Attached file WIP
Hi Yuren, 

Here's another WIP, app config path is built with |APP_DIR| & |GAIA_DEVICE_TYPE|.
Attachment #8417158 - Attachment is obsolete: true
Attachment #8417292 - Flags: feedback?(yurenju.mozilla)
Attachment #8417292 - Flags: feedback?(yurenju.mozilla) → feedback+
Attached file Pull request
Attachment #8417841 - Flags: review?(yurenju.mozilla)
Comment on attachment 8417841 [details] [review]
Pull request

r=yurenju if you throw exception when configPath doesn't exeist.
Attachment #8417841 - Flags: review?(yurenju.mozilla) → review+
Merged to master, r=yurenju
https://github.com/mozilla-b2g/gaia/commit/52f459128686a1fbe4b64fcd89ed8d8ff4ff5bbb
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: