Closed
Bug 1003790
Opened 10 years ago
Closed 10 years ago
Remove linear-gradient -moz- prefixes from spectrum.css
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 32
People
(Reporter: ntim, Assigned: johannes)
Details
(Whiteboard: [good first bug][mentor=ntim][lang=css])
Attachments
(1 file, 1 obsolete file)
1.31 KB,
patch
|
bgrins
:
review+
|
Details | Diff | Splinter Review |
You need to remove the linear-gradient -moz- prefixes in this file : http://dxr.mozilla.org/mozilla-central/source/browser/devtools/shared/widgets/spectrum.css#146 While removing the -moz- prefix, you have to adjust the gradient. (left becomes to right for example) I'm not a peer, so review might need to happen twice.
Assignee | ||
Comment 1•10 years ago
|
||
I'd like to work on it. Could you please assign it to me?
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8415383 -
Flags: review?(ntim007)
Reporter | ||
Comment 3•10 years ago
|
||
Comment on attachment 8415383 [details] [diff] [review] gradients Review of attachment 8415383 [details] [diff] [review]: ----------------------------------------------------------------- Looks good ! Asking an actual peer for a pure review. (Also, please change r=ntim to r=bgrins)
Attachment #8415383 -
Flags: review?(ntim007)
Attachment #8415383 -
Flags: review?(bgrinstead)
Attachment #8415383 -
Flags: review+
Reporter | ||
Updated•10 years ago
|
Assignee: nobody → johannes
Assignee | ||
Comment 4•10 years ago
|
||
Here we go.
Attachment #8415383 -
Attachment is obsolete: true
Attachment #8415383 -
Flags: review?(bgrinstead)
Attachment #8415446 -
Flags: review?(bgrinstead)
Updated•10 years ago
|
Status: NEW → ASSIGNED
Comment 5•10 years ago
|
||
Comment on attachment 8415446 [details] [diff] [review] gradientsV2 Review of attachment 8415446 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me, thanks. You can mark checkin-needed in the keywords field to get this checked in.
Attachment #8415446 -
Flags: review?(bgrinstead) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 6•10 years ago
|
||
Johannes, are you interested in taking on another CSS-related bug? I will mentor - Bug 1004025.
Updated•10 years ago
|
OS: Windows 8.1 → All
Hardware: x86_64 → All
Version: 30 Branch → Trunk
Assignee | ||
Comment 7•10 years ago
|
||
Sure! :)
Comment 8•10 years ago
|
||
Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=72aafcfae44d
Comment 9•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/90980ce65b54
Keywords: checkin-needed
Whiteboard: [good first bug][mentor=ntim][lang=css] → [good first bug][mentor=ntim][lang=css][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/90980ce65b54
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][mentor=ntim][lang=css][fixed-in-fx-team] → [good first bug][mentor=ntim][lang=css]
Target Milestone: --- → Firefox 32
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•