Closed Bug 1003832 Opened 5 years ago Closed 5 years ago

IonMonkey: JSON spewer should add a separator in resume points operands.

Categories

(Core :: JavaScript Engine: JIT, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: nbp, Assigned: nbp)

Details

Attachments

(1 file)

h4writer> nbp, for iongraph. Would it be possible to add lines in the ResumePoint information, indicating a "frame". So we know where a new inlined frame starts?
h4writer> nbp, so something like: "resumepoint 10 9 8 7 6 | 9 10 3 4 2 1"
I still have to test it with iongraph, but the code in iongraph does not seems to assume that we are expecting integer types in the list of operands, so this should just display fine.
Attachment #8415292 - Flags: review?(hv1989)
Comment on attachment 8415292 [details] [diff] [review]
bug1003832-iongraph-inline-frames.patch

Review of attachment 8415292 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome!
Attachment #8415292 - Flags: review?(hv1989) → review+
https://hg.mozilla.org/mozilla-central/rev/03bac8416b9b
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.