Closed
Bug 1003832
Opened 10 years ago
Closed 10 years ago
IonMonkey: JSON spewer should add a separator in resume points operands.
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: nbp, Assigned: nbp)
Details
Attachments
(1 file)
819 bytes,
patch
|
h4writer
:
review+
|
Details | Diff | Splinter Review |
h4writer> nbp, for iongraph. Would it be possible to add lines in the ResumePoint information, indicating a "frame". So we know where a new inlined frame starts? h4writer> nbp, so something like: "resumepoint 10 9 8 7 6 | 9 10 3 4 2 1"
Assignee | ||
Comment 1•10 years ago
|
||
I still have to test it with iongraph, but the code in iongraph does not seems to assume that we are expecting integer types in the list of operands, so this should just display fine.
Attachment #8415292 -
Flags: review?(hv1989)
Comment 2•10 years ago
|
||
Comment on attachment 8415292 [details] [diff] [review] bug1003832-iongraph-inline-frames.patch Review of attachment 8415292 [details] [diff] [review]: ----------------------------------------------------------------- Awesome!
Attachment #8415292 -
Flags: review?(hv1989) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/03bac8416b9b
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/03bac8416b9b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•