1003837 - dumpHeap creates file named "null" if 1st argument is null

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tooru Fujisawa [:arai]]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140421221237

Steps to reproduce:

Run jstests (especially js1_8/extensions/regress-378789.js) with debug build js shell.



Actual results:

File named "null" is created on current directory.



Expected results:

The result should be output to stdout instead of the file.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Output dumpHeap result to stdout when 1st argument is null.

Comment 2

[Tom S [:evilpie]]

Comment on attachment 8415295 [details] [diff] [review]
Output dumpHeap result to stdout when 1st argument is null.

Review of attachment 8415295 [details] [diff] [review]:
-----------------------------------------------------------------

I guess passing undefined would work instead of null, but who cares.

Comment 3

[Tooru Fujisawa [:arai]]

Thank you for reviewing.
Could you push this patch to try server?

Comment 4

[Jason Orendorff [:jorendorff]]

I'm going to push this today.

Comment 5

[Jason Orendorff [:jorendorff]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d0bd512f4df6

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d0bd512f4df6