1003853 - Use the remembered is_desktop_b2g instead of marionette.instance

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Zac C (:zac)]

Use the is_desktop_b2g property instead of marionette.instance incase marionette.instance does not exist (eg after a crash)

Comment 1

[Zac C (:zac)]

Attachment: github pr

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8415302 [details] [review]
github pr

I'm going to r- this in its current state. I don't think b2gdesktop should be implicitly linked to maintaining a gecko instance. Couldn't we just handle the case were marionette.instance throws? The bug doesn't really contain enough information for me to provide any other suggestions.

Comment 3

[Zac C (:zac)]

(In reply to Dave Hunt (:davehunt) from comment #2)
> I don't think b2gdesktop should
> be implicitly linked to maintaining a gecko instance. 

What do you mean by this? I don't understand.

Comment 4

[Zac C (:zac)]

This property comes from marionette's session capabilities so if that's wrong then we should change or clarify it in the is_desktop_b2g property.

Comment 5

[Zac C (:zac)]

Dave sorry I didn't see your PR comments before I wrote these comments!

Comment 6

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to Zac C (:zac) from comment #5)
> Dave sorry I didn't see your PR comments before I wrote these comments!

No problem. Let me know if anything needs clarifying.

Comment 7

[Zac C (:zac)]

OK I'm going to revert this change, but I'll lace "instance" it with a comment instead to explain it

Comment 8

[Zac C (:zac)]

Comment on attachment 8415302 [details] [review]
github pr

Pretty trivial..!

Comment 9

[Zac C (:zac)]

https://github.com/mozilla-b2g/gaia/commit/9f9d4e26658075fe9a27c3102ae4e38fdac71e37