Closed
Bug 1003993
Opened 10 years ago
Closed 10 years ago
FxA System app - remove refs to 'accountId', replace with 'email'
Categories
(Firefox OS Graveyard :: FxA, defect)
Tracking
(b2g-v2.0 fixed)
RESOLVED
FIXED
2.0 S1 (9may)
| Tracking | Status | |
|---|---|---|
| b2g-v2.0 | --- | fixed |
People
(Reporter: jhirsch, Assigned: jhirsch)
References
Details
(Whiteboard: [qa+])
Attachments
(1 file)
Looks like I missed a few spots in bug 984486 updates to support changing the Gecko param from 'accountId' to 'email' (bug 981210).
|
Assignee | |
Updated•10 years ago
|
|
|
Assignee | |
Comment 1•10 years ago
|
||
Since the Gecko change has landed that replaces 'accountId' with 'email', I'm just going to remove all the refs to 'accountId' throughout the FxA system app. To land as rapidly as possible, I'll file a separate bug for the settings app. Updating description accordingly.
Summary: System app code must allow 'accountId' or 'email' → Remove refs to 'accountId', replace with 'email'
|
|
Assignee | |
Updated•10 years ago
|
Summary: Remove refs to 'accountId', replace with 'email' → FxA System app - remove refs to 'accountId', replace with 'email'
|
|
Assignee | |
Comment 2•10 years ago
|
||
|
|
Assignee | |
Comment 3•10 years ago
|
||
Comment on attachment 8415519 [details] [review] Github PR 18839 Hi Fernando - Do you have time for a review? This finishes the accountId -> email transition, now that the related Gecko code has landed. Thanks!
Attachment #8415519 -
Flags: review?(ferjmoreno)
|
||
Comment 4•10 years ago
|
||
Comment on attachment 8415519 [details] [review] Github PR 18839 Using accountId instead of email leaves the door opened for other ids different than the email (phone number for instance), but whatever, we can always change it back if needed. LGTM.
Attachment #8415519 -
Flags: review?(ferjmoreno) → review+
|
|
Assignee | |
Comment 5•10 years ago
|
||
Master: https://github.com/mozilla-b2g/gaia/commit/c63a3bd3ea4a04dce5a7194312df3e04f7f8de72
Status: NEW → RESOLVED
Closed: 10 years ago
status-b2g-v2.0:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [qa+]
Target Milestone: --- → 2.0 S1 (9may)
|
||
Updated•10 years ago
|
blocking-b2g: 2.0? → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•