Closed
Bug 1004017
Opened 10 years ago
Closed 10 years ago
Rename CycleCollectedJSRuntime::NeedCollect() and Collect()
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: mccr8, Assigned: mccr8)
Details
Attachments
(1 file)
|
3.80 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
It would be nice if these were GarbageCollect() instead of Collect(), as it is less ambiguous.
|
Assignee | |
Comment 1•10 years ago
|
||
While I was at it, I made NeedCollect() more explicit about what it is doing. This flips the return value.
Attachment #8415527 -
Flags: review?(bugs)
|
||
Updated•10 years ago
|
Attachment #8415527 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 2•10 years ago
|
||
try run: https://tbpl.mozilla.org/?tree=Try&rev=1f448c344b35 https://hg.mozilla.org/integration/mozilla-inbound/rev/2d5db2f1cd67
|
||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2d5db2f1cd67
Assignee: nobody → continuation
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•