Closed
Bug 1004089
Opened 10 years ago
Closed 10 years ago
frame switching by index in gaia is broken
Categories
(Remote Protocol :: Marionette, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla32
People
(Reporter: mdas, Assigned: automatedtester)
Details
(Keywords: pi-marionette-server)
Attachments
(1 file, 1 obsolete file)
4.77 KB,
patch
|
automatedtester
:
review+
|
Details | Diff | Splinter Review |
Using today's eng build, after it reboots, if you do: m = Marionette() m.start_session() m.switch_to_frame(1) then it'll just hang there, and you'll see this in the logcat: E/GeckoConsole( 506): [JavaScript Error: "frames[msg.json.id] is undefined" {file: "chrome://marionette/content/marionette-listener.js" line: 1874}] Likely due to Bug 929175
Reporter | ||
Updated•10 years ago
|
Priority: -- → P1
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → dburns
Keywords: ateam-marionette-server
Reporter | ||
Comment 1•10 years ago
|
||
Turns out that index based switching is at fault. If I launch contacts and do: m.switch_to_frame(m.find_element(By.CSS_SELECTOR, 'iframe[src*="contacts"]')) this works!
Reporter | ||
Updated•10 years ago
|
Summary: frame switching in gaia is broken → frame switching by index in gaia is broken
Assignee | ||
Comment 2•10 years ago
|
||
I didn't put fall back code for OOP frames, will have a patch shortly
Assignee | ||
Comment 3•10 years ago
|
||
apparently try is needing a reset, cant push to try
Assignee | ||
Comment 4•10 years ago
|
||
comment 3 is in bug 994028
Assignee | ||
Comment 5•10 years ago
|
||
Attachment #8415582 -
Flags: review?(mdas)
Assignee | ||
Comment 6•10 years ago
|
||
Will try try again in the morning
Reporter | ||
Comment 7•10 years ago
|
||
Comment on attachment 8415582 [details] [diff] [review] Allow frame switching in marionette when switching by index and the frame is OOP Review of attachment 8415582 [details] [diff] [review]: ----------------------------------------------------------------- Just remove the pdb stuff and we're good to go ::: testing/marionette/client/marionette/tests/unit/test_switch_remote_frame.py @@ +92,5 @@ > + iframe.style.width = "100%%"; > + iframe.src = "%s"; > + document.body.appendChild(iframe); > + """ % self.marionette.absolute_url("test.html")) > + import pdb; pdb.set_trace() Remove pdb
Attachment #8415582 -
Flags: review?(mdas) → review+
Assignee | ||
Comment 8•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8415582 -
Attachment is obsolete: true
Assignee | ||
Comment 9•10 years ago
|
||
Comment on attachment 8415587 [details] [diff] [review] Allow frame switching in marionette when switching by index and the frame is OOP Review of attachment 8415587 [details] [diff] [review]: ----------------------------------------------------------------- carrying over r+ after nit
Attachment #8415587 -
Flags: review+
Assignee | ||
Comment 10•10 years ago
|
||
landed in http://hg.mozilla.org/integration/mozilla-inbound/rev/20a18be004c7
Comment 11•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/20a18be004c7
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•