Closed Bug 1004104 Opened 10 years ago Closed 10 years ago

Disable caching when running netmonitor tests to hopefully fix some timeouts

Categories

(DevTools :: Netmonitor, defect)

defect
Not set
normal

Tracking

(firefox32 fixed, firefox33 fixed)

RESOLVED FIXED
Firefox 33
Tracking Status
firefox32 --- fixed
firefox33 --- fixed

People

(Reporter: vporof, Assigned: vporof)

Details

Attachments

(1 file, 2 obsolete files)

This function in head.js [0] expects certain events to be fired to decide whether or not a requests was performed and received by the frontend. Sometimes, when requests are cached, one or more of those events [1] aren't fired, because there's no corresponding network activity to trigger them.

Disabling cache might fix those types of oranges.

[0] http://dxr.mozilla.org/mozilla-central/source/browser/devtools/netmonitor/test/head.js#146
[1] http://dxr.mozilla.org/mozilla-central/source/browser/devtools/netmonitor/test/head.js#168
Any luck with this, Victor? :)
victor busy. he will see someday.
Assignee: nobody → vporof
Attached patch v1 (obsolete) — Splinter Review
Going through try.
Attached patch v2 (obsolete) — Splinter Review
Reruns look promising. This patch is even more aggressive and turns off caching on a per-request basis.
Attachment #8436336 - Attachment is obsolete: true
Attached patch v2Splinter Review
Didn't qref properly before.
Attachment #8436361 - Attachment is obsolete: true
Attachment #8436362 - Flags: review?(dcamp)
Attachment #8436362 - Flags: review?(dcamp) → review+
https://hg.mozilla.org/mozilla-central/rev/78abcb1bf52f
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: