Closed
Bug 1004104
Opened 10 years ago
Closed 10 years ago
Disable caching when running netmonitor tests to hopefully fix some timeouts
Categories
(DevTools :: Netmonitor, defect)
DevTools
Netmonitor
Tracking
(firefox32 fixed, firefox33 fixed)
RESOLVED
FIXED
Firefox 33
People
(Reporter: vporof, Assigned: vporof)
Details
Attachments
(1 file, 2 obsolete files)
45.84 KB,
patch
|
dcamp
:
review+
|
Details | Diff | Splinter Review |
This function in head.js [0] expects certain events to be fired to decide whether or not a requests was performed and received by the frontend. Sometimes, when requests are cached, one or more of those events [1] aren't fired, because there's no corresponding network activity to trigger them. Disabling cache might fix those types of oranges. [0] http://dxr.mozilla.org/mozilla-central/source/browser/devtools/netmonitor/test/head.js#146 [1] http://dxr.mozilla.org/mozilla-central/source/browser/devtools/netmonitor/test/head.js#168
Comment 1•10 years ago
|
||
Any luck with this, Victor? :)
Comment 2•10 years ago
|
||
victor busy. he will see someday.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → vporof
Assignee | ||
Comment 3•10 years ago
|
||
Going through try.
Assignee | ||
Comment 4•10 years ago
|
||
Try was green: https://tbpl.mozilla.org/?tree=Try&rev=ad1bde86a7cd
Assignee | ||
Comment 5•10 years ago
|
||
Reruns look promising. This patch is even more aggressive and turns off caching on a per-request basis.
Attachment #8436336 -
Attachment is obsolete: true
Assignee | ||
Comment 6•10 years ago
|
||
Didn't qref properly before.
Attachment #8436361 -
Attachment is obsolete: true
Assignee | ||
Comment 7•10 years ago
|
||
New try run: https://tbpl.mozilla.org/?tree=Try&rev=73e5b8eab97a
Assignee | ||
Updated•10 years ago
|
Attachment #8436362 -
Flags: review?(dcamp)
Updated•10 years ago
|
Attachment #8436362 -
Flags: review?(dcamp) → review+
Assignee | ||
Comment 8•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/78abcb1bf52f
Whiteboard: [fixed-in-fx-team]
Comment 9•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/78abcb1bf52f
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33
Comment 10•10 years ago
|
||
Uplifted to beta32 to simplify uplifting bug 1036895. https://hg.mozilla.org/releases/mozilla-beta/rev/00f079c876f6
status-firefox32:
--- → fixed
status-firefox33:
--- → fixed
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•