This is NOT a dupe of bug 76547. That is a discussion about moving of "Internet Kewords" from the Netscape commercial build. I think this should be off for several reason: 1- The text says "Mozilla Internet Keywords" in the prefs, but there is no such thing. If you hit the info button it goes to "http://www.mozilla.org". 2- This is a commercial feature, that is branded. 3- Mozilla has lots of DNS and name resolution problems that are currently hidden by this feature. For example, bug 95707 really shows how out of date our resolution architecture is... mozilla can't even find... "mozilla". This bug is also relate to the variety of bugs I have filed asking for that would improve the robustness and (for lack of a better word...) modernity of our ability to take stuff users type click on and convert it to the sensible target. Bug 88217 especially, but also issues about handling incomplete URLs that don't have an fqdn.
Mozilla builds are for testing and development purposes. This feature confuses connectivity testing. It should be disabled by default in our testing builds. It would also be useful, for those interested in testing this specific feature, if the button actually pointed to a document explaining what this feature does and how it can be configured. With these two changed I think we can make testing a lot more clear.
When you turn off keywords, you see the change in prefs.js. user_pref("keyword.enabled", false); In all.js, you see: pref("keyword.URL", "http://keyword.netscape.com/keyword/"); pref("keyword.enabled", true); in Netscape 6.1, ns-all.js already has: pref("keyword.enabled", true); I can't find a pref of the "More Info" button's URL, so that is probably in the panel. I'm hacking my prefs now to log how the queries are sent.
I modified my server to accept requests and forward them to the normal URL. The keyword queries are simply the URL encoded string: "quote aol" -> "quote%20aol" after the keyword URL.
OK, can someone please tell me what the URL for "more information" is in Netscape builds (to give me something to work from for a Mozillified version)? I'll then change the URL for that button, and change the pref in all.js to false. I assume that's all this bug is about, right? :-) Some NS person should probably turn it back on in ns-prefs.js. Gerv
I'd finish the mozilla version of the document tonight, and include the netscape URL for the "more info" button in my write-up.
OK. I have a patch to turn this off by default, and point to the explanatory document, which I've checked in as: http://www.mozilla.org/projects/seamonkey/internet-keywords.html The keyword.enabled and keyword.URL prefs are already in all-ns.js, and so it seems we don't actually need any coordination with Netscape. Review requested :-) Gerv
Comment on attachment 51569 [details] [diff] [review] Patch v.2 - changed URL r=doron
Comment on attachment 51569 [details] [diff] [review] Patch v.2 - changed URL sr=shaver
Checked in. Gerv
VERIFIED: I've been testing this default in mozilla 1.0 and later.
There are a few scattered reports of people who want a default behavior in mozilla, where this is on by default. I've duped those bugs into Bug 197918 to track the feedback.