Closed Bug 1004183 Opened 6 years ago Closed 6 years ago

dom/media/MediaManager.cpp:1343:7: error: 'c' was not declared in this scope (--disable-webrtc)


(Core :: WebRTC, defect)

Not set



Tracking Status
firefox31 --- fixed
firefox32 --- fixed


(Reporter: jbeich, Assigned: jbeich)



(Whiteboard: [qa-] )


(1 file)

Attached patch fixSplinter Review
Sparc, MIPS, AArch64, etc. and Solaris still default to --disable-webrtc. OpenBSD downstream also doesn't want WebRTC until PulseAudio dependency is excised (bug 911450 or bug 952828 comment 14).

In file included from dom/media/Unified_cpp_dom_media0.cpp:15:
dom/media/MediaManager.cpp:1343:7: error: use of undeclared identifier 'c'
  if (c.mPicture && !aPrivileged) {
1 error generated.
Attachment #8415585 - Flags: review?(jib)
Comment on attachment 8415585 [details] [diff] [review]

Review of attachment 8415585 [details] [diff] [review]:

Attachment #8415585 - Flags: review?(jib) → review+
Assignee: nobody → jbeich
Closed: 6 years ago
Resolution: --- → FIXED
Comment on attachment 8415585 [details] [diff] [review]

I think this needs to land on aurora/31, since this still fails for me.


[Approval Request Comment]
Bug caused by (feature/regressing bug #): 907352
User impact if declined: failure to build aurora with disable-webrtc
Testing completed (on m-c, etc.): yes
Risk to taking this patch (and alternatives if risky): yolo!
String or IDL/UUID changes made by this patch: none
Attachment #8415585 - Flags: approval-mozilla-aurora?
I'll note for the drivers that --disable-webrtc is NPOTB (at least before the Tarako; fabrice wants to use it there).  There should be no risk taking this on Aurora; if it builds after landing all is good.
Attachment #8415585 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
m-a builds fine with this, 1004194 and 981780 (still using --disable-webrtc)
jib, is this something that would need testing by QA or to be in the testsuite? Thanks!
Flags: needinfo?(jib)
Whiteboard: [qa?]
If by 'this' you mean this particular patch, then no. I think if it builds it should be fine.

If you're asking would it be useful if the test suite could catch these kinds of bugs, then yes, say a new target (perhaps excluded by default) with --disable-webrtc.
Flags: needinfo?(jib)
Flags: in-qa-testsuite?(hskupin)
Whiteboard: [qa?] → [qa-]
I do not see a reason why this should be covered by a QA owned test framework. Not sure if that would even be doable.
Flags: in-testsuite?
Flags: in-qa-testsuite?(hskupin)
Flags: in-qa-testsuite-
You need to log in before you can comment on or make changes to this bug.