Closed Bug 1004218 Opened 10 years ago Closed 10 years ago

[NFC] Smart Poster Action handling should be removed from NfcManager

Categories

(Firefox OS Graveyard :: NFC, defect)

Product:
Firefox OS Graveyard
Component:
NFC
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2.0 S1 (9may)

People

(Reporter: tauzen, Assigned: tauzen)

References

Details

(Whiteboard: [p=1])

Attachments

(1 file)

pull-request-1004218.txt
46 bytes, text/x-github-pull-request
alive
: review+
Details | Review 
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/34.0.1847.131 Safari/537.36

Steps to reproduce:

Currently NfcManager.formatWellKnownRecord method has implemented handling of SMARTPOSTER_ACTION record. This should be removed as well as NfcManager.formatSmartPosterAction method. 

According to NFCForum-SmartPoster_RTD_1.0 Smart Poster action record is a subrecord of Smart Poster (NDEF TNF_WELL_KNOWN RTD_SMART_POSTER). As Smart Posters payload is handled untouched to the app via activity the code in NfcManager.formatSmartPosterAction as well as the code which calls it in NfcManager.formatWellKnownRecord are unreachable.
I would like to work on this.
Blocks: NFC-Gaia
Assignee: nobody → kmioduszewski
This bug blocks NFC 2.0 release.
Blocks: b2g-NFC-2.0

        Attachment #8417282 -
        Flags: review?(alive)

        Attachment #8417282 -
        Flags: review?(alive) → review+

    
  
Keywords: checkin-needed

    
  
Whiteboard: [p=1]
Target Milestone: --- → 2.0 S1 (9may)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: