Closed
Bug 1004311
Opened 11 years ago
Closed 11 years ago
logout button style broken on initial profile creation page
Categories
(Participation Infrastructure :: Phonebook, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: pinkarakas, Assigned: scott.leea)
Details
(Whiteboard: [kb=1375855] )
Attachments
(2 files)
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:26.0) Gecko/20100101 Firefox/26.0 (Beta/Release)
Build ID: 20131205075310
Steps to reproduce:
I was setting my profile page.
Actual results:
Logout button was in a weird position, the top middle position of the page (laying next to a field).
Expected results:
Intuitively, "Logout" button should be placed on the corners of the screen.
Comment 1•11 years ago
|
||
Can you provide a screenshot that shows the weird position of the logout button? Also, which device and browser are you using? Thanks!
Flags: needinfo?(pinkarakas)
Reporter | ||
Comment 2•11 years ago
|
||
logout button should be placed more on the corners rather than sticking to the field box.
Reporter | ||
Comment 3•11 years ago
|
||
(In reply to William Reynolds [:williamr] from comment #1)
> Can you provide a screenshot that shows the weird position of the logout
> button? Also, which device and browser are you using? Thanks!
I've added the screenshot to the attachment.
Ok weird sounds exaggerated, but I really think it should not be so close to the field area.
I'm using Firefox v26 on macbook pro retina 2012.
Thanks.
Updated•11 years ago
|
Assignee: nobody → scott.leea
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Assignee | ||
Comment 4•11 years ago
|
||
(In reply to pinkarakas from comment #3)
> I've added the screenshot to the attachment.
>
> Ok weird sounds exaggerated, but I really think it should not be so close to
> the field area.
>
> I'm using Firefox v26 on macbook pro retina 2012.
>
> Thanks.
I tried replicating this on a Macbook on Firefox v26 and could not see it. I found out that it was appearing only on the staging server (allizom) and that the development and production servers don't use this style anymore.
:hoosteeno what do you recommend moving forward since it seemed like an outdated styling?
Updated•11 years ago
|
Version: 2014-04.6 → other
Comment 5•11 years ago
|
||
http://i.imgur.com/hGz4Mvr.png This bug occurs on dev as well not just stage.
Updated•11 years ago
|
Summary: logout button should be replaced in initial profile setting page → logout button style broken on initial profile creation page
Assignee | ||
Comment 6•11 years ago
|
||
Made the fix, verified, and made a pull request: https://github.com/mozilla/mozillians/pull/955.
Comment 7•11 years ago
|
||
Commits pushed to master at https://github.com/mozilla/mozillians
https://github.com/mozilla/mozillians/commit/b97e48161c3784459545c144aee9b02619a76a29
Bug 1004311 Fixed logout button style.
Fixed css id to correct the button style.
https://github.com/mozilla/mozillians/commit/b733a97481d9211869c3e4af4ece737831834d51
Merge pull request #955 from chefscott/logout_button
Bug 1004311 Fixed logout button style.
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: needinfo?(pinkarakas)
Resolution: --- → FIXED
Version: other → next
Updated•11 years ago
|
Whiteboard: [kb=1375855]
Comment 8•11 years ago
|
||
Verified on stage. Thanks :pancakes9!
Updated•11 years ago
|
Status: RESOLVED → VERIFIED
Updated•11 years ago
|
Version: next → 2014-05.4
You need to log in
before you can comment on or make changes to this bug.
Description
•