1004354 - [NFC] On Shrink UI, after the nfc application is force closed (by long key press of home button), the home button no longer works

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: NFC, defect)

Description

[psiddh]

Steps to reproduce:

1) Bring two  firefox OS Nfc enabled phones together
2) Ensure that there is a gaia nfc application such as (browser) running in foreground/ launched on each device respectively.
3) Observe that UI on browser tilts (on both devices)
4) Now on one of the devices, long key press on 'home button' and close the app (in this case browser) by selecting the 'x' mark on the UI. 
5) Observe that the application is closed and (if there are no other applications running in the background) homescreen is launched / shown.
6) Now launch any other app . 
7) Try selecting home button, and for that matter 'short / normal click on home button' never works until the phone is rebooted

Comment 1

[psiddh]

Reason for such behavior is this, when 'appterminated' event is received by shrinking UI, 'this.current.manifestURL' is null.

Comment 2

[psiddh]

Attachment: (v1) Patch to fix home button usage after nfc application is force closed / killed by user

Hi Greg,
Please provide your feedback. I will submit a pull req soon.
Thanks, Sid

Comment 3

[Ken Chang[:kenkai]]

This bug blocks NFC 2.0 release.

Comment 4

[psiddh]

Greg, do you have any updates on this ?

Comment 5

[Greg Weng [:snowmantw][:gweng][:λ]]

The problem is according to UX, the home button should be disabled when the shinking start, until the user sent the content or the power button got pressed. Would this bug occurs in other cases?

Comment 6

[psiddh]

Thanks Greg for your comments. Home button seem to be functioning ok in the case you mentioned.
The fix that I am providing is in an edge case when shrinking / titled UI occurs, and instead of swiping on the tilted UI, long press home button key and kill the application. From here on 'home button' doesn't work as expected as System app's Shrinking UI module thinks that it is still in 'shrink state'.

Since its been a while since I have tested this scenario on the builds, let me try check this behavior on latest builds and get back to you. If the above problem is not clear, maybe I will try and record a video to make things clearer.

Comment 7

[Greg Weng [:snowmantw][:gweng][:λ]]

> in an edge case when shrinking / titled UI occurs, and instead of swiping on the tilted UI, long press home button key and kill the application

That is what I mentioned: these home button pressing should be discarded. Because there are no behavior can disturb the Shrinking UI except the power button pressing or put the device away from another one. So if the home button still work under Shrinking UI, it's a bug should be fixed. I'll check this later.

Comment 8

[Greg Weng [:snowmantw][:gweng][:λ]]

The long pressing home button should be disabled at the Bug 997595.

Comment 9

[psiddh]

This issue can be set to resolved state now that 'Bug 997595' lands. I tested it out on the latest builds.