Closed Bug 1004376 Opened 10 years ago Closed 10 years ago

[Skia] Remove Moz2D requirement for SK_SUPPORT_LEGACY_GETTOTALCLIP

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla33

People

(Reporter: gw280, Assigned: wlitwinczyk)

Details

Attachments

(1 file, 1 obsolete file)

skia_bug_1004376
2.26 KB, patch
gw280
: review+
Details | Diff | Splinter Review 
Skia are deprecating their getTotalClip API, and to ease the transition the old ones are still available behind an ifdef SK_SUPPORT_LEGACY_GETTOTALCLIP

We should remove our usage of this old API and switch to the new one.

Ideal as an intern bug.
Assignee: nobody → wlitwinczyk
Attached patch Removed legacy enabling define (obsolete) — — Splinter Review 
This one was actually as simple as removing the flag.
Attachment #8427374 - Flags: review?(gwright)
Attachment #8427374 - Flags: review?(gwright) → review+
Attached patch skia_bug_1004376 — — Splinter Review 
Try revealed a problem with the Android build.
Attachment #8427374 - Attachment is obsolete: true
Attachment #8443616 - Flags: review?(gwright)
Attachment #8443616 - Flags: review?(gwright) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/69d293514ef3
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: