Closed
Bug 1004411
Opened 11 years ago
Closed 11 years ago
Tour floating cta button needs min-height
Categories
(www.mozilla.org :: Pages & Content, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: yfdyh000, Assigned: agibson)
Details
(Whiteboard: [kb=1351877])
Attachments
(1 file)
The https://www.mozilla.org/en-US/firefox/29.0/firstrun/ is normal.
But https://www.mozilla.org/zh-CN/firefox/29.0/firstrun/ is the icon be truncate, due to it's text is only one line.
for example: .floating-cta { min-height: 58px }
In addition, why use "’" U+2019 instead of "'" U+0027?
|
Assignee | |
Updated•11 years ago
|
Summary: "Take the tour to see what’s new" button need min-height → Tour floating cta button needs min-height
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → agibson
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•11 years ago
|
||
|
||
Comment 3•11 years ago
|
||
Commits pushed to master at https://github.com/mozilla/bedrock
https://github.com/mozilla/bedrock/commit/885cc9bdb58fffbab9c2fe866e787e9bb6b4f93b
[fix bug 1004411] Tour floating cta button needs min-height
https://github.com/mozilla/bedrock/commit/58332a819b96abb9944ddf2f5324faf1c07df4ba
Merge pull request #1961 from alexgibson/bug-1004411-tour-floating-cta-button-needs-min-height
[fix bug 1004411] Tour floating cta button needs min-height (zh-CN)
|
|
||
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•