Closed
Bug 1004500
Opened 10 years ago
Closed 10 years ago
Document imgIContainer::FLAG_WANT_DATA_SURFACE
Categories
(Core :: Graphics: ImageLib, defect)
Core
Graphics: ImageLib
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: jwatt, Assigned: jwatt)
References
Details
Attachments
(1 file)
1.16 KB,
patch
|
seth
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8415901 -
Flags: review?(seth)
Comment 2•10 years ago
|
||
Comment on attachment 8415901 [details] [diff] [review] patch Review of attachment 8415901 [details] [diff] [review]: ----------------------------------------------------------------- ::: image/public/imgIContainer.idl @@ +155,5 @@ > + /** > + * Can be passed to GetFrame when the caller wants a DataSourceSurface > + * instead of a hardware accelerated surface. This can be important for > + * performance (by avoiding an upload to/readback from the GPU) when the > + * caller knows they want a SourceSurface of type DATA. Thanks, looks good! I'd add the explanation to the block comment directly above the list of the flags instead of here, though.
Attachment #8415901 -
Flags: review?(seth) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0276c57cffba (In reply to Seth Fowler [:seth] from comment #2) > I'd add the explanation to the block comment directly > above the list of the flags instead of here, though. That would meant that Doxygen and other tools would associate the comment with the wrong enum value though, so I left it as-is.
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0276c57cffba
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•