Document imgIContainer::FLAG_WANT_DATA_SURFACE

RESOLVED FIXED in mozilla32

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

Trunk
mozilla32
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Posted patch patchSplinter Review
Attachment #8415901 - Flags: review?(seth)
Comment on attachment 8415901 [details] [diff] [review]
patch

Review of attachment 8415901 [details] [diff] [review]:
-----------------------------------------------------------------

::: image/public/imgIContainer.idl
@@ +155,5 @@
> +  /**
> +   * Can be passed to GetFrame when the caller wants a DataSourceSurface
> +   * instead of a hardware accelerated surface. This can be important for
> +   * performance (by avoiding an upload to/readback from the GPU) when the
> +   * caller knows they want a SourceSurface of type DATA.

Thanks, looks good! I'd add the explanation to the block comment directly above the list of the flags instead of here, though.
Attachment #8415901 - Flags: review?(seth) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/0276c57cffba

(In reply to Seth Fowler [:seth] from comment #2)
> I'd add the explanation to the block comment directly
> above the list of the flags instead of here, though.

That would meant that Doxygen and other tools would associate the comment with the wrong enum value though, so I left it as-is.
https://hg.mozilla.org/mozilla-central/rev/0276c57cffba
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.