1004505 - ./flash.sh gaia fails on latest master

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

When I run ./flash.sh gaia, I get the following error:

-----------------------------------
In production moderemount succeeded
Exception: SyntaxError: JSON.parse: expected ',' or '}' after property value in object at line 1 column 13 of the JSON data
CommonjsRunner.prototype.run@/Users/kats/zspace/B2G-master/gaia/build/xpcshell-commonjs.js:56:1
run@/Users/kats/zspace/B2G-master/gaia/build/xpcshell-commonjs.js:84:3
@-e:1:1

make: *** [preferences] Error 3
-----------------------------------

The invalid JSON is because the BUILD_CONFIG environment variable starts of like this:

  { "ADB" : ""adb"", "GAIA_DIR" ... }

Note the double sets of quote marks around the ADB value. This seems to be coming from a combination of the flash.sh script, where we have
  GAIA_MAKE_FLAGS="ADB=\"$ADB\""
and the Gaia makefile, where BUILD_CONFIG is defined including this:
      "ADB" : "$(ADB)",

One of these sets of quotes should be stripped. I changed the Makefile locally to remove the quotes and that worked around the problem.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Strip existing quotes before re-quoting $(ADB)

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Thanks for the fix.