1004593 - nsTraceRefCnt::Startup() does nothing and isn't called anywhere

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Andrew McCreight [:mccr8]]

That's confusing if you put something in there and expect it to do something.  The "startup" it does seems to all be in InitTraceLog, which is called on AddRef and Release.

Comment 1

[Andrew McCreight [:mccr8]]

This would also be a good bug to delete the comment: " I hope to turn this on for everybody once we hit it a little less."

At some point, the thing the comment refers to was only enabled for dbaron, but now it is in all debug builds.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Remove the unused nsTraceRefCnt::Startup().

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8465829 [details] [diff] [review]
Remove the unused nsTraceRefCnt::Startup().

Review of attachment 8465829 [details] [diff] [review]:
-----------------------------------------------------------------

I guess this was there for symmetry, but there doesn't seem to be much point to symmetry if the symmetric function isn't called...

Comment 4

[Andrew McCreight [:mccr8]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5b1d8268ae17

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5b1d8268ae17