Build failure on with VS2013 with --enable-warnings-as-errors due to: Warning C4996: 'GetVersionExA': was declared deprecated in TestUDPSocket.cpp

RESOLVED FIXED in mozilla32

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: briansmith, Assigned: briansmith)

Tracking

Trunk
mozilla32
All
Windows 8.1
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

No description provided.
Attachment #8416045 - Flags: review?(jduell.mcbugs)

Comment 1

5 years ago
Comment on attachment 8416045 [details] [diff] [review]
fix-warning-in-TestUDPSocket.patch

Review of attachment 8416045 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't know you're a Windows guy Brian :)

Thanks for the patch!
Attachment #8416045 - Flags: review?(jduell.mcbugs) → review+
Please use !IsVistaOrLater() instead.
Blocks: 960397
Blocks: VC12
https://hg.mozilla.org/mozilla-central/rev/11de3d4530be
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32

Comment 5

5 years ago
> Please use !IsVistaOrLater() instead.

Is that important enough to back this out or land a new patch over it?
Flags: needinfo?(VYV03354)
(In reply to Jason Duell (:jduell) from comment #5)
> > Please use !IsVistaOrLater() instead.
> 
> Is that important enough to back this out or land a new patch over it?

It is enough to land a new patch over.
Flags: needinfo?(VYV03354)
You need to log in before you can comment on or make changes to this bug.