Closed
Bug 1004642
Opened 10 years ago
Closed 10 years ago
Build failure on with VS2013 with --enable-warnings-as-errors due to: Warning C4996: 'GetVersionExA': was declared deprecated in TestUDPSocket.cpp
Categories
(Core :: Networking, defect)
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: briansmith, Assigned: briansmith)
References
Details
Attachments
(1 file)
1.04 KB,
patch
|
jduell.mcbugs
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8416045 -
Flags: review?(jduell.mcbugs)
Comment 1•10 years ago
|
||
Comment on attachment 8416045 [details] [diff] [review] fix-warning-in-TestUDPSocket.patch Review of attachment 8416045 [details] [diff] [review]: ----------------------------------------------------------------- I didn't know you're a Windows guy Brian :) Thanks for the patch!
Attachment #8416045 -
Flags: review?(jduell.mcbugs) → review+
Assignee | ||
Comment 2•10 years ago
|
||
Thanks for the review. https://hg.mozilla.org/integration/mozilla-inbound/rev/11de3d4530be
Comment 3•10 years ago
|
||
Please use !IsVistaOrLater() instead.
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/11de3d4530be
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Comment 5•10 years ago
|
||
> Please use !IsVistaOrLater() instead.
Is that important enough to back this out or land a new patch over it?
Flags: needinfo?(VYV03354)
Comment 6•10 years ago
|
||
(In reply to Jason Duell (:jduell) from comment #5) > > Please use !IsVistaOrLater() instead. > > Is that important enough to back this out or land a new patch over it? It is enough to land a new patch over.
Flags: needinfo?(VYV03354)
You need to log in
before you can comment on or make changes to this bug.
Description
•