Closed Bug 1004665 Opened 10 years ago Closed 10 years ago

Experiments: exception thrown if activating experiment with crash reporting disabled

Categories

(Firefox Health Report Graveyard :: Client: Desktop, defect)

Product:
Firefox Health Report Graveyard
Component:
Client: Desktop
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox31 fixed, firefox32 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 32
Tracking Flags:
Tracking Status
firefox31 --- fixed
firefox32 --- fixed

People

(Reporter: benjamin, Assigned: benjamin)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

bug1004665-telex-crashreporter-disabled
1.15 KB, patch
gfritzsche
: review+
Sylvestre
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
I see an exception in my browser console if I activate an experiment in a local build where crash reporting is built but not enabled (the default for local builds).

        Attachment #8416464 -
        Flags: review?(georg.fritzsche)

        Attachment #8416464 -
        Flags: review?(georg.fritzsche) → review+
OS: Windows 7 → All
Hardware: x86_64 → All

    
    

    
  
https://hg.mozilla.org/integration/fx-team/rev/19b40165000e
Target Milestone: --- → Firefox 32
Version: unspecified → Trunk

    
    

    
  
I think this needs uplift for 31 as well?
Flags: needinfo?(benjamin)

    
    

    
  
Comment on attachment 8416464 [details] [diff] [review]
bug1004665-telex-crashreporter-disabled

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Experiments
User impact if declined: If crash reporting is disabled, experiments will not function or will be disabled unnecessarily.
Testing completed (on m-c, etc.): Landed, works
Risk to taking this patch (and alternatives if risky): Very low risk
String or IDL/UUID changes made by this patch: none

        Attachment #8416464 -
        Flags: approval-mozilla-aurora?
Flags: needinfo?(benjamin)

        Attachment #8416464 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

    
  
Whiteboard: [qa-]

    
  
Product: Firefox Health Report → Firefox Health Report Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: