Closed
Bug 1004693
Opened 10 years ago
Closed 10 years ago
[e10s] Add keyword search does not work
Categories
(Firefox :: General, defect)
Tracking
()
VERIFIED
FIXED
Firefox 32
Tracking | Status | |
---|---|---|
e10s | + | --- |
People
(Reporter: hkaimenas, Assigned: evilpie)
References
(Blocks 1 open bug)
Details
(Whiteboard: [e10s])
Attachments
(1 file)
994 bytes,
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0 (Beta/Release) Build ID: 20140501030202 Steps to reproduce: 1. Go to http://dxr.mozilla.org/mozilla-central/source/ 2. Right click on the search box and select Add a Keyword for this search... Actual results: Nothing happens Expected results: It should bring up a popup allowing to set a new bookmark along with a keyword. Works in non-e10s Nightly.
Reporter | ||
Updated•10 years ago
|
Whiteboard: [e10s]
Assignee | ||
Updated•10 years ago
|
tracking-e10s:
--- → ?
Assignee | ||
Comment 1•10 years ago
|
||
I think this basically enough to make it work. What do you think?
Comment 2•10 years ago
|
||
Comment on attachment 8417548 [details] [diff] [review] v1 Review of attachment 8417548 [details] [diff] [review]: ----------------------------------------------------------------- If tests pass, sure! Let's just send it to try before landing
Attachment #8417548 -
Flags: review?(felipc) → review+
Updated•10 years ago
|
Depends on: old-e10s-m2
Updated•10 years ago
|
Blocks: old-e10s-m2
No longer depends on: old-e10s-m2
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc437fb80144 https://tbpl.mozilla.org/?tree=Try&rev=cf07075a144e
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fc437fb80144
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 32
Comment 5•10 years ago
|
||
Reproduced the initial issue on an older nightly (2014-04-30), using the reporter's steps. This is now verified fixed on: * Firefox 32 Beta 8 (Build ID: 20140818191513), * Aurora 33.0a1 (2014-08-19), * Nightly 34.0a1 (2014-08-19), using Windows 7 64-bit and Mac OS X 10.9.4.
Status: RESOLVED → VERIFIED
Keywords: verifyme
You need to log in
before you can comment on or make changes to this bug.
Description
•