1004702 - Use KHR_debug in DebugMode(), when available

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Kelsey Gilbert [:jgilbert]]

We added support for KHR_debug in bug 910429, but haven't done anything in the tree with it. We should lean on it for at least DebugMode() runs.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: use-khr-debug

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 8416115 [details] [diff] [review]
use-khr-debug

Review of attachment 8416115 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLContext.cpp
@@ +1227,5 @@
> +    case LOCAL_GL_DEBUG_SOURCE_OTHER:
> +        sourceStr = "SOURCE_OTHER";
> +        break;
> +    default:
> +        sprintf(sourceBuffer, "<source 0x%04x>", source);

Instead of the relatively unsafe sprintf, or the safer but still bug-prone PR_snprintf, please use a nsPrintfCString or whatever it's called.

Comment 3

[Kelsey Gilbert [:jgilbert]]

Attachment: use-khr-debug

r=bjacob

Comment 4

[Kelsey Gilbert [:jgilbert]]

Attachment: for landing

r=bjacob
Needed to use GLAPIENTRY for StaticDebugCallback on Windows.

Comment 5

[Kelsey Gilbert [:jgilbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/46a5bfb1fab7

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/46a5bfb1fab7