Closed Bug 1004716 Opened 10 years ago Closed 10 years ago

merging profiles doesn't sync markers properly

Categories

(Core :: Gecko Profiler, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: BenWa, Assigned: BenWa)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch patch (obsolete) — Splinter Review
Markers used to be attached to the near sample (and had slightly incorrect timestamps). They were moved to their unique entity in the profile format with their own unique timestamps.

The merge scripts need to take that into account now when syncing.
Attachment #8416129 - Flags: review?(ehsan)
I think this patch includes the start time double precision fix from bug 1004677 as well?
Attached patch patchSplinter Review
Nope, fixed!
Assignee: nobody → bgirard
Attachment #8416129 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8416129 - Flags: review?(ehsan)
Attachment #8416149 - Flags: review?(ehsan)
Attachment #8416149 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/71110537b22f
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.