1004721 - [Camera] 2.0 Visual Design refresh of top panel viewfinder icons

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect, P1)

Description

[Amy Lee [:amylee] UX]

This refresh is for the 3 top panel icons in the camera viewfinder (rear/front camera toggle, on/off auto flash, and settings menu). Will attach icons once they are ready. 

p.s is there a meta bug to track 2.0 camera bugs? 

Thanks!

Comment 1

[Hema Koka [:hema]]

Justin or Wilson, can one of you take this?

Comment 2

[Justin D'Arcangelo [:justindarc]]

Hema: I'll take a look at this tomorrow morning.

Comment 3

[Justin D'Arcangelo [:justindarc]]

Amy: Can you attach the new icons and/or the updated spec for 2.0 to this bug? Thanks!

Comment 4

[Wilson Page [:wilsonpage]]

Please attach SVGs not PNGs. Mr. Justin is taking, shout if you need any icon-font pointers :)

Comment 5

[Hema Koka [:hema]]

amlee, do you have the icons?

Comment 6

[Hema Koka [:hema]]

adding swilkes to help get these icons since amy seems to be ooo till june 10th

Comment 7

[Amy Lee [:amylee] UX]

(In reply to Justin D'Arcangelo [:justindarc] from comment #3)
> Amy: Can you attach the new icons and/or the updated spec for 2.0 to this
> bug? Thanks!

Hi Justin, 

I don't think these will be ready for the 2.0 release. Pushing this to 2.1 since it's not a priority. Thanks!

Comment 8

[Stephany Wilkes]

Hema, are you OK with this moving to 2.1? Definitely your call.

Comment 9

[Hema Koka [:hema]]

(In reply to Stephany Wilkes from comment #8)
> Hema, are you OK with this moving to 2.1? Definitely your call.

Fine with me. Thanks!

Comment 10

[Amy Lee [:amylee] UX]

Attachment: Camera_Top_Menu_Icons.zip

Here are the icons that need to be swapped out. If this can be squeezed into 2.0 that would be great! I understand if we can't make this happen though.

Comment 11

[Justin D'Arcangelo [:justindarc]]

Attachment: pull-request (master)

Diego: Pretty simple patch. Added some additional test coverage for the `HudController` while I was in there. Removed some methods that are no longer in use.

Amy: Check to make sure icons look ok.

Comment 12

[Amy Lee [:amylee] UX]

Attachment: Camera_Top_Menu_Icons_v2.zip

Hi Justin, 

The flash icon has an odd gap in the shape. I didn't merge the shape layers and I think it's reading the SVG improperly. Can you replace the flash icon in all states with the ones in this zip file?

Also, can you make the following edits:

1. Front/Rear Camera icon - Please make this 3 rems (centered to circle)
2. Flash Icon - Please make this 3.2 rems and move it 1px to the left (all states)
3. Options Icon - Please make this 3 rems (centered to circle)  

Thanks!

Comment 13

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8443742 [details] [review]
pull-request (master)

Amy: Updated the PR to update the flash icons and address your comments. Please re-review. Thanks!

Comment 14

[Amy Lee [:amylee] UX]

Comment on attachment 8443742 [details] [review]
pull-request (master)

This looks good! Thanks Justin

Comment 15

[Diego Marcos [:dmarcos]]

Comment on attachment 8443742 [details] [review]
pull-request (master)

It looks good! Ship it!

Comment 16

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-b2g/gaia/commit/c7a5c6e78b4e3717f25f9e0d0cef8fdfbb3044cd