1004835 - Discarding review request should obsolete the attachment

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect, P1)

Description

[Mark Côté [:mcote]]

When a review request is created, it posts its URL as an attachment to the associated bug.  It would be good, if the review request is discarded, to obsolete the associated bug attachment, particularly since reopening the review request will result in another attachment (with the same content, though possibly a different reviewer) being added to the bug.

Comment 1

[Sayan Paul]

How to get started with the bug? I would like to contribute.

Comment 2

[Mark Côté [:mcote]]

Hi!  You'll need to do two things first: get a working Bugzilla setup, and get Review Board with the rbbz extension installed.  For the first, you can install the developer vagrant box from the instructions at https://wiki.mozilla.org/BMO/DeveloperBox.  For the second, check out http://www.reviewboard.org/docs/codebase/dev/getting-started/ and then install the extension from https://github.com/mozilla/rbbz.  The last link is where you'll actually be modifying code.

Comment 3

[Sayan Paul]

Ok I will start setting up the whole environment..

Comment 4

[Mark Côté [:mcote]]

There are a lot of little tasks related to the Review Board tool, so after you've done this initial setup you'll be able to reuse it to fix other bugs, if you're interested. :)

Let me know if you have any problems.  Feel free to join irc.mozilla.org in the #bteam or #bmo channels if you want live help!

Comment 5

[Mark Côté [:mcote]]

It is becoming obvious that it's still a fair bit of work to set everything up.  I'm removing the [good first bug] tag until we have a nicely packaged docker/vagrant setup with everything in one place.

Comment 6

[Gregory Szorc [:gps]]

Just ran into this bug. It was very annoying. Bumping to P1. Will work on fix.

Comment 7

[Gregory Szorc [:gps]]

Attachment: MozReview Request: bz://1004835/gps

Comment 8

[Gregory Szorc [:gps]]

/r/37 - reviewboard: verify state of Bugzilla when discarding review requests
/r/39 - reviewboard: print is_obsolete flag for attachments
/r/41 - reviewboard: obsolete review attachments when discarding review request (bug 1004835)
/r/43 - reviewboard: reuse obsoleted attachments

Pull down these commits:

hg pull review -r 8abebf8c09450b3d4f4ac5ef1ff8fe43e5fae162

Comment 9

[Steven MacLeod [:smacleod]]

https://reviewboard.mozilla.org/r/37/#review123

Ship It!

Comment 10

[Steven MacLeod [:smacleod]]

https://reviewboard.mozilla.org/r/39/#review125

Ship It!

Comment 11

[Steven MacLeod [:smacleod]]

https://reviewboard.mozilla.org/r/41/#review127

Ship It!

Comment 12

[Steven MacLeod [:smacleod]]

https://reviewboard.mozilla.org/r/43/#review129

Ship It!

Comment 13

[Steven MacLeod [:smacleod]]

https://reviewboard.mozilla.org/r/35/#review131

Ship It!

Comment 14

[Gregory Szorc [:gps]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/4dcf5d9d6767

Comment 16

[Gregory Szorc [:gps]]

Attachment: MozReview Request: reviewboard: obsolete review attachments when discarding review request (bug 1004835)

Comment 17

[Gregory Szorc [:gps]]

Attachment: MozReview Request: reviewboard: reuse obsoleted attachments

Comment 18

[Gregory Szorc [:gps]]

Attachment: MozReview Request: reviewboard: verify state of Bugzilla when discarding review requests

Comment 19

[Gregory Szorc [:gps]]

Attachment: MozReview Request: reviewboard: print is_obsolete flag for attachments