Closed Bug 1004835 Opened 7 years ago Closed 7 years ago

Discarding review request should obsolete the attachment

Categories

(MozReview Graveyard :: General, defect, P1)

Production
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mcote, Unassigned, Mentored)

References

Details

Attachments

(4 files, 1 obsolete file)

When a review request is created, it posts its URL as an attachment to the associated bug.  It would be good, if the review request is discarded, to obsolete the associated bug attachment, particularly since reopening the review request will result in another attachment (with the same content, though possibly a different reviewer) being added to the bug.
Whiteboard: [good first bug][lang=python]
Whiteboard: [good first bug][lang=python] → [good first bug][lang=python][mentor=mcote]
How to get started with the bug? I would like to contribute.
Flags: needinfo?(mcote)
Hi!  You'll need to do two things first: get a working Bugzilla setup, and get Review Board with the rbbz extension installed.  For the first, you can install the developer vagrant box from the instructions at https://wiki.mozilla.org/BMO/DeveloperBox.  For the second, check out http://www.reviewboard.org/docs/codebase/dev/getting-started/ and then install the extension from https://github.com/mozilla/rbbz.  The last link is where you'll actually be modifying code.
Flags: needinfo?(mcote)
Ok I will start setting up the whole environment..
There are a lot of little tasks related to the Review Board tool, so after you've done this initial setup you'll be able to reuse it to fix other bugs, if you're interested. :)

Let me know if you have any problems.  Feel free to join irc.mozilla.org in the #bteam or #bmo channels if you want live help!
Mentor: mcote
Whiteboard: [good first bug][lang=python][mentor=mcote] → [good first bug][lang=python]
It is becoming obvious that it's still a fair bit of work to set everything up.  I'm removing the [good first bug] tag until we have a nicely packaged docker/vagrant setup with everything in one place.
Whiteboard: [good first bug][lang=python]
Depends on: 1047465
Product: bugzilla.mozilla.org → Developer Services
Just ran into this bug. It was very annoying. Bumping to P1. Will work on fix.
Status: NEW → ASSIGNED
Priority: P2 → P1
Attached file MozReview Request: bz://1004835/gps (obsolete) —
Attachment #8513762 - Flags: review?(smacleod)
/r/37 - reviewboard: verify state of Bugzilla when discarding review requests
/r/39 - reviewboard: print is_obsolete flag for attachments
/r/41 - reviewboard: obsolete review attachments when discarding review request (bug 1004835)
/r/43 - reviewboard: reuse obsoleted attachments

Pull down these commits:

hg pull review -r 8abebf8c09450b3d4f4ac5ef1ff8fe43e5fae162
Attachment #8513762 - Flags: review?(smacleod) → review+
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Attachment #8513762 - Attachment is obsolete: true
Attachment #8618154 - Flags: review+
Attachment #8618155 - Flags: review+
Attachment #8618156 - Flags: review+
Attachment #8618157 - Flags: review+
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.