Closed
Bug 1004835
Opened 8 years ago
Closed 8 years ago
Discarding review request should obsolete the attachment
Categories
(MozReview Graveyard :: General, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mcote, Unassigned, Mentored)
References
Details
Attachments
(4 files, 1 obsolete file)
When a review request is created, it posts its URL as an attachment to the associated bug. It would be good, if the review request is discarded, to obsolete the associated bug attachment, particularly since reopening the review request will result in another attachment (with the same content, though possibly a different reviewer) being added to the bug.
Reporter | ||
Updated•8 years ago
|
Whiteboard: [good first bug][lang=python]
Reporter | ||
Updated•8 years ago
|
Whiteboard: [good first bug][lang=python] → [good first bug][lang=python][mentor=mcote]
Comment 1•8 years ago
|
||
How to get started with the bug? I would like to contribute.
Flags: needinfo?(mcote)
Reporter | ||
Comment 2•8 years ago
|
||
Hi! You'll need to do two things first: get a working Bugzilla setup, and get Review Board with the rbbz extension installed. For the first, you can install the developer vagrant box from the instructions at https://wiki.mozilla.org/BMO/DeveloperBox. For the second, check out http://www.reviewboard.org/docs/codebase/dev/getting-started/ and then install the extension from https://github.com/mozilla/rbbz. The last link is where you'll actually be modifying code.
Flags: needinfo?(mcote)
Comment 3•8 years ago
|
||
Ok I will start setting up the whole environment..
Reporter | ||
Comment 4•8 years ago
|
||
There are a lot of little tasks related to the Review Board tool, so after you've done this initial setup you'll be able to reuse it to fix other bugs, if you're interested. :) Let me know if you have any problems. Feel free to join irc.mozilla.org in the #bteam or #bmo channels if you want live help!
Assignee | ||
Updated•8 years ago
|
Mentor: mcote
Whiteboard: [good first bug][lang=python][mentor=mcote] → [good first bug][lang=python]
Reporter | ||
Comment 5•8 years ago
|
||
It is becoming obvious that it's still a fair bit of work to set everything up. I'm removing the [good first bug] tag until we have a nicely packaged docker/vagrant setup with everything in one place.
Whiteboard: [good first bug][lang=python]
Assignee | ||
Updated•8 years ago
|
Product: bugzilla.mozilla.org → Developer Services
Comment 6•8 years ago
|
||
Just ran into this bug. It was very annoying. Bumping to P1. Will work on fix.
Status: NEW → ASSIGNED
Priority: P2 → P1
Comment 7•8 years ago
|
||
Attachment #8513762 -
Flags: review?(smacleod)
Comment 8•8 years ago
|
||
/r/37 - reviewboard: verify state of Bugzilla when discarding review requests /r/39 - reviewboard: print is_obsolete flag for attachments /r/41 - reviewboard: obsolete review attachments when discarding review request (bug 1004835) /r/43 - reviewboard: reuse obsoleted attachments Pull down these commits: hg pull review -r 8abebf8c09450b3d4f4ac5ef1ff8fe43e5fae162
Comment 9•8 years ago
|
||
https://reviewboard.mozilla.org/r/37/#review123 Ship It!
Comment 10•8 years ago
|
||
https://reviewboard.mozilla.org/r/39/#review125 Ship It!
Comment 11•8 years ago
|
||
https://reviewboard.mozilla.org/r/41/#review127 Ship It!
Comment 12•8 years ago
|
||
https://reviewboard.mozilla.org/r/43/#review129 Ship It!
Updated•8 years ago
|
Attachment #8513762 -
Flags: review?(smacleod) → review+
Comment 13•8 years ago
|
||
https://reviewboard.mozilla.org/r/35/#review131 Ship It!
Updated•8 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Comment 15•7 years ago
|
||
Attachment #8513762 -
Attachment is obsolete: true
Attachment #8618154 -
Flags: review+
Attachment #8618155 -
Flags: review+
Attachment #8618156 -
Flags: review+
Attachment #8618157 -
Flags: review+
Comment 16•7 years ago
|
||
Comment 17•7 years ago
|
||
Comment 18•7 years ago
|
||
Comment 19•7 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Product: Developer Services → MozReview
You need to log in
before you can comment on or make changes to this bug.
Description
•