Closed
Bug 1004915
Opened 10 years ago
Closed 10 years ago
Rename FoundTooManyMatches in to reflect new string content
Categories
(Toolkit :: Find Toolbar, defect)
Toolkit
Find Toolbar
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: flod, Assigned: mikedeboer)
References
()
Details
Attachments
(1 file)
2.37 KB,
patch
|
Unfocused
:
review+
|
Details | Diff | Splinter Review |
I'm sorry but this is not the way strings are supposed to be changed https://developer.mozilla.org/en-US/docs/Making_String_Changes Changeset http://hg.mozilla.org/mozilla-central/diff/3c60a233a26d/toolkit/locales/en-US/chrome/global/findbar.properties The existing string FoundTooManyMatches has been completely changed. Please change the ID for this string.
Assignee | ||
Comment 1•10 years ago
|
||
Ah, thanks for catching this! I'll change it right away.
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•10 years ago
|
||
Blair, this was a small oversight on my part. I simply renamed this one string.
Attachment #8416385 -
Flags: review?(bmcbride)
Updated•10 years ago
|
Attachment #8416385 -
Flags: review?(bmcbride) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Thanks! Pushed as https://hg.mozilla.org/integration/fx-team/rev/d07c627b749f
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d07c627b749f
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•