Closed Bug 1004967 Opened 6 years ago Closed 6 years ago

[NFC] NDEF TNF External Type should be handled properly in NfcManager

Categories

(Firefox OS Graveyard :: NFC, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
2.0 S1 (9may)

People

(Reporter: tauzen, Assigned: tauzen)

References

Details

(Whiteboard: [p=1])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
alive
: review+
Details | Review
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/34.0.1847.131 Safari/537.36

Steps to reproduce:

Currently NfcManager when handling NDEF TNF External Type creates MozActivity with the data.type = 'external-type' and data.rtd = record.type. To be consistent with NDEF handling in NfcManager and according to the spec the data.type should be string representation of record.type, data.rtd should be removed.
I have a test case for that and would like to work on this.
Blocks: NFC-Gaia
Component: General → NFC
Depends on: 1000981
Assignee: nobody → kmioduszewski
Attached file Pull Request
Attachment #8417989 - Flags: review?(alive)
Comment on attachment 8417989 [details] [review]
Pull Request

thanks!
Attachment #8417989 - Flags: review?(alive) → review+
Keywords: checkin-needed
master: https://github.com/mozilla-b2g/gaia/commit/2529fb24f0e2d7c6b5decd87ae50902b363361ca
Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S1 (9may)
Whiteboard: [p=1]
You need to log in before you can comment on or make changes to this bug.