1005038 - In-content preferences: the pages from the Sync tab are loaded in current tab

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[Camelia Badau [:cbadau], Desktop QA]

Reproducible on the latest Nightly (BuildID: 20140501030202) 
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:32.0) Gecko/20100101 Firefox/32.0
Reproducible on the latest Aurora (BuildID: 20140502004003)
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0

Steps to reproduce: 
1. Open about:preferences. 
2. Go to Sync tab and click on the "Sign In", "Create Account" or "Using an older version of Sync?" option. 

Actual results: The pages are loaded in current tab, not in a new tab. The in-content preferences page is closed. 

Expected results: The pages are loaded in a new tab. The in-content preferences page remains opened in current tab. 

Notes: This bug is reproducible also on Mac OSX 10.7.5 and Ubuntu 13.10 32bit.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Bug1005038-newTab.patch

This let's open the links in a new tab.

Jared, what do you think? I could also remove whole "if (!win) {}" part as we are using the in-content prefs and have a browser window. Thus this check isn't needed and we only need to open a new tab.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8416526 [details] [diff] [review]
Bug1005038-newTab.patch

Review of attachment 8416526 [details] [diff] [review]:
-----------------------------------------------------------------

Can you please file a follow-up bug to clean up this file? There is a lot of code that is around in the case that there is no recent window, but with in-content preferences I don't see how we could have the preferences open without a recent window.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Ah, I didn't see your note in comment #1. Yes, I agree, but let's do that in a follow-up bug, and include tests in that one as well.

Comment 4

[Carsten Book [:Tomcat]]

Hi, could you provide a Try link. Suggestions for what to run if you haven't
yet can be found here:
https://wiki.mozilla.org/Sheriffing/How:To:Recommended_Try_Practices

Comment 5

[Richard Marti (:Paenglab)]

Try build: https://tbpl.mozilla.org/?tree=Try&rev=575298e70f7d

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/cc62c0f430af

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cc62c0f430af

Comment 8

[YaoMingWang]

Reproduced with Nightly from 2014-05-02 with STR from comment 0.
Verified as fixed on latest Nightly 32.0a1 (Build Id: 20140514030203) on Windows 7 x64:
Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:32.0) Gecko/20100101 Firefox/32.0

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

Thanks!