Closed Bug 1005081 Opened 6 years ago Closed 5 years ago
.9-5 .9% tp5o regression for osx 10 .6/win7 on aurora (v31) uplift, missing fix from 985017
On the uplift this week, we have two tp5o regressions reported. Here is a friendly link to a graph: http://graphs.mozilla.org/graph.html#tests=[[255,52,21],[255,52,25]]&sel=1396451047316,1399043047317&displayrange=30&datatype=running This was a confusing bug- we never had a regression for tp5o on inbound (v31), so why did we regress on uplift? I found out that we had a perf win on Aurora (v30) when bug 985017 landed! Yay for wins, but we never landed this fix on trunk. I recommend landing this fix in 31 (current aurora) and 32 (current trunk)
:mwu, is there any chance we could land the perf win from bug 985017 on future branches like fx 32/33? (it is too late for 31)
Bug 985017 only applied to the old thebes based image drawing code. It disappeared when the image drawing code was converted to Moz2D, so there's nothing to land. Also, the optimization only applies when we're using volatile images, which is not the case.
any concerns with closing this as wontfix?
Do we know what specific pages regressed? Or was it across the board?
I have looked at the data which is the improvement patch that landed in early april: https://datazilla.mozilla.org/?start=1396303940&stop=1397037267&product=Firefox&repository=Mozilla-Aurora&os=mac&os_version=OS%20X%2010.6.8&test=tp5o&graph_search=60c9101d5304&x86=true&x86_64=true&project=talos I don't see any single page that shows a big improvement. As for regressions about half show regressions: https://datazilla.mozilla.org/?start=1398360899&stop=1399463835&product=Firefox&repository=Mozilla-Aurora&os=mac&os_version=OS%20X%2010.6.8&test=tp5o&graph_search=60c9101d5304,4974d9da2f7d&tr_id=5309236&graph=bbc.co.uk&x86=true&x86_64=true&project=talos You can see the improvements and regressions here: http://graphs.mozilla.org/graph.html#tests=[[255,52,21],[255,52,25]]&sel=1392228337139.5938,1400400209931.113,0,500&displayrange=365&datatype=running
we have shipped this.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.